Hide Forgot
Description of problem: Please see https://beaker.engineering.redhat.com/recipes/331315 The distro is identified as :: [ LOG ] :: Distro: : Red Hat Desktop release 4 (Nahant Update 9) however, the conditional code path after "if rlIsRHEL 4" does not trigger
I think problem is somewhere here: > __INTERNAL_rlIsDistro(){ > local distro="$(lsb_release -ds)" > local whole="$(lsb_release -rs)" > local major="$(lsb_release -rs | cut -d '.' -f 1)" > echo $distro | grep -q "$1" || return 1 > shift > [ -z "$1" ] && return 0 > for arg in $@ > do > if [ "$arg" == "$whole" ] || [ "$arg" == "$major" ] > then > return 0 > fi > done > return 1 > } > rlIsRHEL(){ > __INTERNAL_rlIsDistro "Red Hat Enterprise Linux" "$@" > } As on RHEL5 Update 9 # cat /etc/redhat-release Red Hat Desktop release 4 (Nahant Update 9) # lsb_release -ds "Red Hat Desktop release 4 (Nahant Update 9)" So there is not string "Red Hat Enterprise Linux" but "Red Hat Desktop release". It would be very nice to have this fixed... like really really nice... (Maybe > rlIsRHEL(){ > __INTERNAL_rlIsDistro "Red Hat Enterprise Linux" "$@" \ > || __INTERNAL_rlIsDistro "Red Hat Desktop release" "$@" > } might do the trick...)
http://git.fedorahosted.org/git?p=beakerlib.git;a=commit;h=f20344d3c749e31c6be81c5657cd71ab90b13e64
seems that it works ... from http://beaker-archive.app.eng.bos.redhat.com/beaker-logs/2013/01/3569/356958/752028/9892042/TESTOUT.log RHEL4 - turn off selinux check selinux-policy-targeted-sources-1.17.30-2.152.el4 :: [ PASS ] :: Checking for the presence of selinux-policy-targeted-sources rpm :: [13:42:04] :: [ INFO ] :: No initdb in RHEL4/5 ^ these three are triggered by rlIsRHEL and the release string is: :: [ LOG ] :: Distro: : Red Hat Desktop release 4 (Nahant Update 9) so, VERIFIED, and I guess it may get closed as well, thanks for fixing!