Hide Forgot
Created attachment 534659 [details] fix to include only glib.h Description of problem: claws-mail-plugins can currently not be built as claws-mail provides the broken header file claws-mail/common/defs.h Version-Release number of selected component (if applicable): claws-mail in Rawhide How reproducible: 100% Steps to Reproduce: 1. fedpkg clone claws-mail-plugins 2. fedpkg build --scratch Actual results: Building the package fail with: In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0, from /usr/include/claws-mail/common/defs.h:27, from archiver_prefs.c:24: /usr/include/glib-2.0/glib/gmacros.h:32:2: error: #error "Only <glib.h> can be included directly." In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0, from /usr/include/claws-mail/common/defs.h:27, from archiver_gtk.c:26: /usr/include/glib-2.0/glib/gmacros.h:32:2: error: #error "Only <glib.h> can be included directly." Expected results: Functional rebuilt of claws-mail-plugins. Additional info: The rebuilt of claws-mail-plugins is needed for the new libarchive (.so bump). Only after fixing the claws-mail/common/defs.h, claws-mail-plugins can be rebuilt successfully. With the attached patch, claws-mail still builds without issues: - http://koji.fedoraproject.org/koji/taskinfo?taskID=3527447
> the broken header file claws-mail/common/defs.h It's not broken. It just requires an update for the breakage introduced by glib 2.31: http://lists.fedoraproject.org/pipermail/devel/2011-October/158746.html
> > the broken header file claws-mail/common/defs.h > > It's not broken. It just requires an update for the breakage introduced by > glib 2.31: > http://lists.fedoraproject.org/pipermail/devel/2011-October/158746.html Correct, it is not broken, it was just missed in the update that makes claws-mail work with the new glib. Thanks for looking into this!
Went ahead and fixed this myself since there have been attempts at rebuilding the -plugins package.