Bug 755727 - Review Request: telepathy-farstream - Telepathy client library to handle Call channels
Summary: Review Request: telepathy-farstream - Telepathy client library to handle Call...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 797694
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-21 21:28 UTC by Brian Pepple
Modified: 2012-03-16 21:12 UTC (History)
2 users (show)

Fixed In Version: telepathy-farstream-0.2.2-2.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-16 21:12:49 UTC
Type: ---
Embargoed:
notting: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Brian Pepple 2011-11-21 21:28:55 UTC
Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec
SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.1.2-1.fc16.src.rpm
Description: telepathy-farstream is a Telepathy client library that uses Farsight2 to handle Call channels

Scratch build (Rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=3530748

Comment 1 Bill Nottingham 2012-02-28 20:47:12 UTC
This package would appear to need some s/farsight/farstream work done, and updated to 0.2.1?

Comment 2 Brian Pepple 2012-02-28 21:34:01 UTC
(In reply to comment #1)
> This package would appear to need some s/farsight/farstream work done, and
> updated to 0.2.1?

Right. I'm still sorting out the deps that it needs.

Comment 3 Brian Pepple 2012-03-04 22:14:15 UTC
Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec
SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.2.1-1.fc16.src.rpm

i386 build results: http://bpepple.fedorapeople.org/rpms/tp-farstream/

Description: telepathy-farstream is a Telepathy client library that uses
Farsight2 to handle Call channels

Comment 4 Bill Nottingham 2012-03-05 20:24:57 UTC
- Package meets naming and packaging guidelines - ***

Description and URL need /farsight/farsteam/ substitutions.

- Spec file matches base package name. - OK
- Spec has consistent macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - LGPLv2+ (OK)
- License field in spec matches - OK
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum:  - OK
409036c07dcd7d8729ff9c84366c8967  telepathy-farstream-0.2.1.tar.gz

- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK

- Headers/static libs in -devel subpackage. - OK
- Spec has needed ldconfig in post and postun - OK
- .pc files in -devel subpackage/requires pkgconfig - OK
- .so files in -devel subpackage. - OK
- -devel package Requires: %{name} = %{version}-%{release} -OK
- .la files are removed. - OK
 
- Package is a GUI app and has a .desktop file - N/A

- Package compiles and builds on at least one arch. - tested x86_64 w/mock
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own.  -OK
- Package owns all the directories it creates.  - OK 
- No rpmlint output. - ***

telepathy-farstream.src:37: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 37)

- final provides and requires are sane: ***

telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded.

SHOULD Items:

- Should build in mock. - tested x86_64
- Should build on all supported archs - didn't test
- Should function as described. - didn't test
- Should have sane scriptlets. - OK
- Should have subpackages require base package with fully versioned depend. - OK
- Should have dist tag  - OK
- Should package latest version - OK

Issues:

1. Description and URL need /farsight/farsteam/ substitutions.
2. Spaces & tabs in the spec
3. telepathy-farsight & telepathy-farsight-devel provides should likely use %{version}, not be hardcoded.

Comment 5 Brian Pepple 2012-03-05 21:12:30 UTC
Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-farstream.spec
SRPM URL:
http://bpepple.fedorapeople.org/rpms/telepathy-farstream-0.2.1-2.fc16.src.rpm

Diff: http://bpepple.fedorapeople.org/rpms/spec.diff

* Mon Mar  5 2012 Brian Pepple <bpepple> - 0.2.1-2
- Use macro for version in provides.
- Change reference Farsight in description to Farstream.

Didn't change reference to url, since as of Saturday a page for tp-farstream didn't exist. freedesktop.org appears to be down right, so I can't check to see if this has changed since then.

Comment 6 Bill Nottingham 2012-03-05 21:25:30 UTC
Looks good. APPROVED.

Comment 7 Brian Pepple 2012-03-05 21:28:25 UTC
New Package SCM Request
=======================
Package Name: telepathy-farstream
Short Description: Telepathy client library to handle Call channels
Owners: bpepple
Branches: f17
InitialCC:

Comment 8 Jens Petersen 2012-03-06 07:15:08 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2012-03-06 19:21:33 UTC
empathy-3.3.91-1.fc17,telepathy-farstream-0.2.1-2.fc17,farstream-0.1.1-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/empathy-3.3.91-1.fc17,telepathy-farstream-0.2.1-2.fc17,farstream-0.1.1-4.fc17

Comment 10 Fedora Update System 2012-03-11 00:57:15 UTC
pidgin-2.10.1-4.fc17,papyon-0.5.6-3.fc17,farstream-0.1.1-4.fc17,telepathy-farstream-0.2.2-1.fc17,empathy-3.3.91-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/pidgin-2.10.1-4.fc17,papyon-0.5.6-3.fc17,farstream-0.1.1-4.fc17,telepathy-farstream-0.2.2-1.fc17,empathy-3.3.91-2.fc17

Comment 11 Fedora Update System 2012-03-16 21:12:49 UTC
telepathy-farstream-0.2.2-2.fc17, farstream-0.1.1-5.fc17, amsn-0.98.4-10.fc17, pidgin-2.10.1-4.fc17, papyon-0.5.6-3.fc17, empathy-3.3.91-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.