Hide Forgot
Description of problem: Since https://bugzilla.redhat.com/show_bug.cgi?id=729355 adds log rotation for /var/log/brcm-iscsi.log in RHEL 5.8 iscsi-initiator-utils it is redundant to include log rotation configs for the same file in ovirt-node (see 633919 and 703995).. (who knows it may cause a conflict and break log rotation of this file?)
https://bugzilla.redhat.com/show_bug.cgi?id=729355#c4 " I'm just wondering if we should have the ovirt-node guys remove their configuration for brcm-iscsi.log https://bugzilla.redhat.com/show_bug.cgi?id=703995#c5 # cat /etc/logrotate.d/ovirt-node /var/log/ovirt*.log /var/log/mcelog /var/log/brcm-iscsi.log { rotate 3 compress missingok size 1M create } # cat /etc/cron.d/ovirt-logrotate # Run each log rotation every 10 minutes */10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/ovirt-node */10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/syslog " Will it conflict with the configuration provided by iscsi-initiator-utils ? https://bugzilla.redhat.com/show_bug.cgi?id=729355#c5 "You might still need it for compat reasons? It should not conflict because of a renaming. The new daemon/log is named iscsiuio. The old one was named brcm something. So if the user did not update the iscsi tools then the ovirt people would still need their rule." probably this bug is not relevant.
Shouldn't conflict, but cleaner to remove it. And there is no risk of having an old iscsi-initiator-tools package since RHEVH is a single unit and single package updates are not supported.
Created attachment 542711 [details] Patch
Checked the latest 5.8 build: rhev-hypervisor5-5.8-20111214.0.el5, the patch is in it. So verified this bug as the following test steps: [root@intel-x3470-8-1 ~]# cat /etc/logrotate.d/ovirt-node /var/log/ovirt*.log /var/log/mcelog { rotate 3 compress missingok size 1M create } [root@intel-x3470-8-1 ~]# ls /etc/logrotate.d/* /etc/logrotate.d/acpid /etc/logrotate.d/subscription-manager /etc/logrotate.d/iscsiuiolog /etc/logrotate.d/syslog /etc/logrotate.d/libvirtd /etc/logrotate.d/up2date /etc/logrotate.d/ovirt-node /etc/logrotate.d/vdsm /etc/logrotate.d/rpm /etc/logrotate.d/vdsm-reg /etc/logrotate.d/snmpd [root@intel-x3470-8-1 ~]# rpm -qa|grep iscsi iscsi-initiator-utils-6.2.0.872-12.el5 [root@intel-x3470-8-1 ~]# rpm -ql iscsi-initiator-utils-6.2.0.872-12.el5 /etc/iscsi /etc/iscsi/iscsid.conf /etc/logrotate.d/iscsiuiolog /etc/rc.d/init.d/iscsi /etc/rc.d/init.d/iscsid /sbin/iscsi-iname /sbin/iscsiadm /sbin/iscsid /sbin/iscsistart /sbin/iscsiuio /usr/include/fw_context.h /usr/include/iscsi_list.h /usr/include/libiscsi.h /usr/lib64/libfwparam.a /usr/lib64/libiscsi.so /usr/lib64/libiscsi.so.0 /usr/lib64/python2.4/site-packages/libiscsimodule.so /usr/share/doc/iscsi-initiator-utils-6.2.0.872 /usr/share/doc/iscsi-initiator-utils-6.2.0.872/README /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/annotated.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/doxygen.css /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/doxygen.png /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/files.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/functions.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/functions_vars.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/globals.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/globals_defs.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/globals_enum.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/globals_eval.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/globals_func.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/globals_vars.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/index.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/libiscsi_8c.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/libiscsi_8h-source.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/libiscsi_8h.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/namespaces.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/namespacesetup.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/pylibiscsi_8c.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/setup_8py.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structPyIscsiChapAuthInfo.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structPyIscsiNode.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structlibiscsi__auth__info.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structlibiscsi__chap__auth__info.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structlibiscsi__context.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structlibiscsi__network__config.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/structlibiscsi__node.html /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/tab_b.gif /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/tab_l.gif /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/tab_r.gif /usr/share/doc/iscsi-initiator-utils-6.2.0.872/html/tabs.css /usr/share/man/man8/iscsi-iname.8.gz /usr/share/man/man8/iscsiadm.8.gz /usr/share/man/man8/iscsid.8.gz /usr/share/man/man8/iscsistart.8.gz /usr/share/man/man8/iscsiuio.8.gz /var/lib/iscsi /var/lib/iscsi/ifaces /var/lib/iscsi/isns /var/lib/iscsi/nodes /var/lib/iscsi/send_targets /var/lib/iscsi/slp /var/lib/iscsi/static /var/lock/iscsi [root@intel-x3470-8-1 ~]# cat /etc/logrotate.d/iscsiuiolog /var/log/iscsiuio.log { weekly missingok notifempty rotate 4 sharedscripts postrotate pkill -USR1 iscsiuio 2> /dev/null || true endscript }
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: The brcm-iscsi.log file was being logrotated with the ovirt.log file because it was not otherwise rotated. The log has been renamed and is now handled correctly by it's own package, so it's being removed from ovirt-node's configuration.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1 @@ -The brcm-iscsi.log file was being logrotated with the ovirt.log file because it was not otherwise rotated. The log has been renamed and is now handled correctly by it's own package, so it's being removed from ovirt-node's configuration.+The brcm-iscsi.log file was previously logrotated with the ovirt.log file because it was not otherwise rotated. The log has been renamed and is now has a specific log rotation configuration.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2012-0168.html