Spec URL: http://dbruno.fedorapeople.org/python-libcloud/python-libcloud.spec SRPM URL: http://dbruno.fedorapeople.org/python-libcloud/python-liblcoud-0.6.2-2.fc15.src.rpm Description: libcloud is a client library for interacting with many of the popular cloud server providers. It was created to make it easy for developers to build products that work between any of the services that it supports.
I had a typo on description the correct SRPM URL: http://dbruno.fedorapeople.org/python-libcloud/python-libcloud-0.6.2-2.fc15.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ! = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [-]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [-]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [-]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-libcloud-0.6.2-2.fc17.noarch.rpm python-libcloud.noarch: W: summary-ended-with-dot C A standard Python library that abstracts away differences among multiple cloud provider APIs. python-libcloud.noarch: E: summary-too-long C A standard Python library that abstracts away differences among multiple cloud provider APIs. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint python-libcloud-0.6.2-2.fc17.src.rpm python-libcloud.src: W: summary-ended-with-dot C A standard Python library that abstracts away differences among multiple cloud provider APIs. python-libcloud.src: E: summary-too-long C A standard Python library that abstracts away differences among multiple cloud provider APIs. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/haikel/756491/apache-libcloud-0.6.2.tar.bz2 : MD5SUM this package : f14bc9896fbcedebadddac68b3e11762 MD5SUM upstream package : f14bc9896fbcedebadddac68b3e11762 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [-]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. rpmlint python-libcloud-0.6.2-2.fc17.noarch.rpm python-libcloud.noarch: W: summary-ended-with-dot C A standard Python library that abstracts away differences among multiple cloud provider APIs. python-libcloud.noarch: E: summary-too-long C A standard Python library that abstracts away differences among multiple cloud provider APIs. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint python-libcloud-0.6.2-2.fc17.src.rpm python-libcloud.src: W: summary-ended-with-dot C A standard Python library that abstracts away differences among multiple cloud provider APIs. python-libcloud.src: E: summary-too-long C A standard Python library that abstracts away differences among multiple cloud provider APIs. 1 packages and 0 specfiles checked; 1 errors, 1 warnings. General and Python specific guidelines are globally respected, you should shorten the summary up to 60 characters (ie: A Python library to address multiple cloud provider APIs) and remove the final dot. Since it does not provide documentation, i would recommend that you add instead demos and examples as they're self-contained. Apart the summary defects, there's no other blocker.
The summary was standardized. SPEC URL: http://dbruno.fedorapeople.org/python-libcloud/python-libcloud.spec SRPM URL: http://dbruno.fedorapeople.org/python-libcloud/python-libcloud-0.6.2-3.fc16.src.rpm rpmlint output: 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
All valid points above remains ok and the summary has been fixed so there's no more blocker. I approve python-libcloud to join Fedora Package Collection. Have a pleasant happy new year eve !
New Package SCM Request ======================= Package Name: python-libcloud Short Description: A Python library to address multiple cloud provider APIs Owners: dbruno Branches: f15 f16 f17 InitialCC:
Git done (by process-git-requests). f17==devel, no need to explicitly request.
@Daniel: python-libcloud has been imported and built (F15/16/17) 3 weeks ago but you didn't issue any bodhi requests, so it hasn't even reached updates-testing. Could you fix it as soon as possible so we can close this ticket ?
python-libcloud-0.6.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-libcloud-0.6.2-3.fc16
python-libcloud-0.6.2-3.fc16 has been pushed to the Fedora 16 testing repository.
python-libcloud-0.6.2-3.fc16 has been pushed to the Fedora 16 stable repository.
Package Change Request ====================== Package Name: python-libcloud New Branches: el5 el6 Owners: dbruno This package is required for saltcloud that will be pushed soon by herlo.
Git done (by process-git-requests).
Package Change Request ====================== Package Name: pkgname New Branches: epel7 Owners: dbruno terminalmage
WARNING: Package does not appear to exist in pkgdb currently.
I'm sorry, I made a copy/paste mistake. Follow the correct request: Package Change Request ====================== Package Name: python-libcloud New Branches: epel7 Owners: dbruno terminalmage