Bug 756636 - Review Request: gnome-screenshot - A screenshot utility for GNOME
Summary: Review Request: gnome-screenshot - A screenshot utility for GNOME
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-24 04:59 UTC by Matthias Clasen
Modified: 2011-12-21 16:32 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2011-12-21 16:32:16 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Matthias Clasen 2011-11-24 04:59:43 UTC
This used to be part of gnome-utils. gnome-utils has been split into individual applications, which is why there is an Obsoletes here. Once all the individual pieces are packages, gnome-utils will go away.

The desktop file in here does not validate, since it contains non-standard Canonical extensions. This is unfortunate, but needs to be addressed upstream.

Spec: http://mclasen.fedorapeople.org/gnome-screenshot.spec
SRPM: http://mclasen.fedorapeople.org/gnome-screenshot-3.3.1-1.fc16.src.rpm

Comment 1 Parag AN(पराग) 2011-11-24 10:16:59 UTC
Review:-

+ koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3537183

+ rpmlint on rpms gave
gnome-screenshot.src:35: W: macro-in-comment %{_datadir}
gnome-screenshot.x86_64: W: obsolete-not-provided gnome-utils
gnome-screenshot.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-screenshot-3.3.1/COPYING
gnome-screenshot.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-screenshot.desktop file contains group "Screen Shortcut Group", but groups extending the format should start with "X-"
gnome-screenshot.x86_64: E: invalid-desktopfile /usr/share/applications/gnome-screenshot.desktop file contains group "Window Shortcut Group", but groups extending the format should start with "X-"
2 packages and 0 specfiles checked; 3 errors, 2 warnings.

+ source verified with upstream as (sha1sum)
734ecd3ee4f2ccbd463754ec5b28b54fcd54c4c3  gnome-screenshot-3.3.1.tar.xz
734ecd3ee4f2ccbd463754ec5b28b54fcd54c4c3  ../SOURCES/gnome-screenshot-3.3.1.tar.xz

+ follows packaging guidelines.

Suggestions:
1) you can fix the macro-in-comment rpmlint warning using %% instead of %

2) also you can ask upstream to update fsf address.

3) Has the desktop issue already reported in upstream?

APPROVED.

Comment 2 Parag AN(पराग) 2011-12-21 10:11:32 UTC
any updates here?

Comment 3 Matthias Clasen 2011-12-21 14:13:25 UTC
Thanks Parag, I'll address your suggestions when I do the initial upload.

To answer your question: the desktop file extensions are being discussed on xdg-list, currently.

Comment 4 Matthias Clasen 2011-12-21 14:19:09 UTC
New Package SCM Request
=======================
Package Name: gnome-screenshot
Short Description: A screenshot utility for GNOME
Owners: mclasen, cosimoc
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2011-12-21 14:37:05 UTC
Git done (by process-git-requests).

Comment 6 Matthias Clasen 2011-12-21 16:32:16 UTC
build underway


Note You need to log in before you can comment on or make changes to this bug.