Bug 759758 - Review Request: perl-Encode-HanExtra - Extra sets of Chinese encodings
Summary: Review Request: perl-Encode-HanExtra - Extra sets of Chinese encodings
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-03 16:14 UTC by Xavier Bachelot
Modified: 2011-12-22 19:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-22 19:28:05 UTC
Type: ---
Embargoed:
ville.skytta: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Xavier Bachelot 2011-12-03 16:14:38 UTC
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-HanExtra.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-Encode-HanExtra-0.23-1.fc15.src.rpm
Description: 
Perl 5.7.3 and later ships with an adequate set of Chinese encodings,
including the commonly used CP950, CP936 (also known as GBK), Big5 (alias
for Big5-Eten), Big5-HKSCS, EUC-CN, HZ, and ISO-IR-165.
However, the numbers of Chinese encodings are staggering, and a complete
coverage will easily increase the size of perl distribution by several
megabytes; hence, this CPAN module tries to provide the rest of them.
If you are using Perl 5.8 or later, Encode::CN and Encode::TW will
automatically load the extra encodings for you, so there's no need to
explicitly write use Encode::HanExtra if you are using one of them already.


This module is needed for better test coverage in perl-MIME-Charset.

Comment 1 Ville Skyttä 2011-12-20 21:23:30 UTC
Same three "see rpmdevtools perl spec template" issues as in bug 759760 (zero-length *.bs, OPTIMIZE, and unnecessary dir ownership).

Comment 3 Ville Skyttä 2011-12-21 07:28:20 UTC
Um, now OPTIMIZE= is in the %setup line...

Comment 4 Xavier Bachelot 2011-12-21 09:25:35 UTC
oops, I shouldn't do this sort of stuff too late at night. Sorry about that.

Spec URL: http://www.bachelot.org/fedora/SPECS/perl-Encode-HanExtra.spec
SRPM URL:
http://www.bachelot.org/fedora/SRPMS/perl-Encode-HanExtra-0.23-3.fc15.src.rpm

Comment 5 Ville Skyttä 2011-12-21 19:47:36 UTC
Looks good now.

Comment 6 Xavier Bachelot 2011-12-21 20:19:26 UTC
Thanks for the review, Ville.

New Package SCM Request
=======================
Package Name: perl-Encode-HanExtra
Short Description: Extra sets of Chinese encodings
Owners: xavierb
Branches: f15 f16 el5 el6
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2011-12-21 20:21:12 UTC
Git done (by process-git-requests).

Comment 8 Xavier Bachelot 2011-12-22 19:28:05 UTC
Imported and build for Rawhide, F16, F15, EL6 and EL5.


Note You need to log in before you can comment on or make changes to this bug.