From Bugzilla Helper: User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Q312461) Description of problem: When getkey is invoked with a wait period but no wait message, it core dumps. Also, there should be an option to allow getkey to ignore Control-C and Control- D characters. It's inability to avoid these characters can cause problems when dealing with the Linux Progress Patch. When we used getkey to check for a keypress in order to reset a machine's environment and reboot, it would always do so when using the Linux Progress Patch, whether or not the key was actually pressed. Finally, a NULL character passed to getkey will be interpreted as a successful match against it's list of characters. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Type "getkey -c 5 d" and wait. Actual Results: You get garbage characters, repeated 5 times, followed by a segmentation fault. Expected Results: It should have waited 5 seconds for the d key, then ended gracefully. Additional info:
Created attachment 80666 [details] source code fix, and enhancements (such as --help message)
Created attachment 80667 [details] Makefile for changed getkey
Also added popt library usage, to provide long aliases for options and help messages. Made getkey fail if no list of characters is provided -- was that last change a good idea? Maybe that last bit should be removed?
Created attachment 80704 [details] Improved source code file -- removed memory leak, restored allowing no keys to be specified, so that any key being hit can be captured, as was the case before.
*** Bug 76070 has been marked as a duplicate of this bug. ***
Added in 7.03-1, thanks!