Bug 761094 - Review Request: asn1c - An ASN.1 Compiler
Summary: Review Request: asn1c - An ASN.1 Compiler
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jakub Hrozek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-07 17:10 UTC by Nathaniel McCallum
Modified: 2012-05-28 05:32 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-28 05:32:11 UTC
Type: ---
Embargoed:
jhrozek: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Nathaniel McCallum 2011-12-07 17:10:52 UTC
Spec URL: http://npmccallum.fedorapeople.org/asn1c/asn1c.spec
SRPM URL: http://npmccallum.fedorapeople.org/asn1c/asn1c-0.9.21-1.fc16.src.rpm
Description: Compiles ASN.1 data structures into C source structures that can be simply marshalled to/unmarshalled from: BER, DER, CER, BASIC-XER, CXER, EXTENDED-XER, PER.

Comment 1 Nathaniel McCallum 2011-12-07 17:13:58 UTC
asn1c.x86_64: W: spelling-error %description -l en_US marshalled -> marshaled, marshal led, marshal-led
asn1c.x86_64: W: spelling-error %description -l en_US unmarshalled -> marshaled
asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/unber.1.gz 11: warning: macro `Dt' not defined
asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/asn1c.1.gz 1: warning: macro `Dt' not defined
asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/enber.1.gz 11: warning: macro `Dt' not defined
asn1c.x86_64: W: no-manual-page-for-binary clyx2asn1.pl
asn1c.x86_64: W: no-manual-page-for-binary crfc2asn1.pl
1 packages and 1 specfiles checked; 0 errors, 110 warnings.
[nmccallu@localhost SPECS]$ rpmlint /home/remote/nmccallu/RPMs/RPMS/x86_64/asn1c-0.9.21-1.fc16.x86_64.rpm asn1c.spec
asn1c.x86_64: W: spelling-error %description -l en_US marshalled -> marshaled, marshal led, marshal-led
asn1c.x86_64: W: spelling-error %description -l en_US unmarshalled -> marshaled
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constraints.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_system.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_CHOICE.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_decoder.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constraints.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_decoder.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_CHOICE.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_decoder.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_decoder.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_encoder.c
asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/unber.1.gz 11: warning: macro `Dt' not defined
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/TeletexString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/T61String.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/TeletexString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/der_encoder.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/der_encoder.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_support.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_support.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/REAL.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_codecs.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BOOLEAN.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/IA5String.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BOOLEAN.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/IA5String.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BMPString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralizedTime.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BMPString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralizedTime.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_SEQUENCE_OF.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_SEQUENCE_OF.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/VisibleString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/VisibleString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GraphicString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeInteger.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BIT_STRING.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GraphicString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/BIT_STRING.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeInteger.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_support.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_codecs_prim.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_support.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_codecs_prim.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTF8String.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTF8String.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_tlv_tag.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTCTime.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UTCTime.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_tlv_tag.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/VideotexString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/VideotexString.h
asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/asn1c.1.gz 1: warning: macro `Dt' not defined
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ObjectDescriptor.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_SET_OF.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ISO646String.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NumericString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_application.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_SET_OF.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ObjectDescriptor.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/asn_internal.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NumericString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ISO646String.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/REAL.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NULL.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UniversalString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/converter-sample.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NULL.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/T61String.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/UniversalString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/OBJECT_IDENTIFIER.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/OCTET_STRING.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SET.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/OBJECT_IDENTIFIER.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/OCTET_STRING.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/INTEGER.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ENUMERATED.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/GeneralString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SEQUENCE_OF.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ENUMERATED.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/INTEGER.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SEQUENCE_OF.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ANY.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_tlv_length.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ber_tlv_length.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/ANY.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeReal.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SEQUENCE.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_TYPE.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SET_OF.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SEQUENCE.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeReal.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_encoder.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/xer_encoder.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SET.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_SET_OF.h
asn1c.x86_64: W: manual-page-warning /usr/share/man/man1/enber.1.gz 11: warning: macro `Dt' not defined
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_decoder.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/constr_TYPE.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/PrintableString.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/PrintableString.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/RELATIVE-OID.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/RELATIVE-OID.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_encoder.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeEnumerated.c
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/per_decoder.h
asn1c.x86_64: W: devel-file-in-non-devel-package /usr/share/asn1c/NativeEnumerated.h
asn1c.x86_64: W: no-manual-page-for-binary clyx2asn1.pl
asn1c.x86_64: W: no-manual-page-for-binary crfc2asn1.pl

Source files are used by asn1c during ASN.1 compilation

Comment 2 Nathaniel McCallum 2011-12-07 17:19:21 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3572760

Comment 3 Jakub Hrozek 2011-12-08 12:20:43 UTC
I see one issue with the package - it creates both /usr/share/doc/asn1c-0.9.21/ and /usr/share/doc/asn1c/ with contents that look the same to me.

Other than that, this package is OK. The sheer number of rpmlint warnings can't be avoided in this case, the code needs to be available at runtime in order for asn1c to work.

Comment 4 Nathaniel McCallum 2011-12-10 05:24:49 UTC
Updated with the fix to remove the duplicate docs directory.

Spec URL: http://npmccallum.fedorapeople.org/asn1c/asn1c.spec
SRPM URL: http://npmccallum.fedorapeople.org/asn1c/asn1c-0.9.21-2.fc16.src.rpm

Comment 5 Jakub Hrozek 2011-12-11 19:41:22 UTC
A koji scratch build - http://koji.fedoraproject.org/koji/taskinfo?taskID=3578426

Thanks for the change. The package is APPROVED now.

Comment 6 Nathaniel McCallum 2012-02-13 16:27:47 UTC
New Package SCM Request
=======================
Package Name: asn1c
Short Description: An ASN.1 Compiler
Owners: npmccallum
Branches: f16 f17 master
InitialCC:

Comment 7 Gwyn Ciesla 2012-02-13 16:34:25 UTC
Git done (by process-git-requests).

Comment 8 Peter Lemenkov 2012-03-31 09:40:12 UTC
Built but still not submitted to Bodhi.

* http://koji.fedoraproject.org/koji/packageinfo?packageID=13294
* https://admin.fedoraproject.org/updates/search/asn1c

Ping, Nathaniel!

Comment 9 Peter Lemenkov 2012-05-28 05:32:11 UTC
Ok, now packages are available for F-17 and F-18 so it's time to close this.


Note You need to log in before you can comment on or make changes to this bug.