Hide Forgot
Locks do not get cleaned up in protocol/server when the application does just an fd close, without explicitly unlocking the held locks. They get cleaned up only when the client is down.
In fact, server is not leaking posix locks. protocol/server does not maintain a lock table for posix locks and passes the flush along and locks translator cleans up accordingly. Same case with release cbk. However, inodelks and entrylks are always explicitly unlocked. Nevertheless, they are cleaned in pl_forget if any are present in the locks translator, which indicates a bug in the user of inodelks/entrylks. Since, protocol/server adds and removes internal locks during lock and unlock requests respectively, there is not really a bug i.e. no locks remain in the lock table of protocol server. Marking this invalid.