Bug 762765 (GLUSTER-1033) - io-threads doesn't log its options
Summary: io-threads doesn't log its options
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-1033
Product: GlusterFS
Classification: Community
Component: io-threads
Version: mainline
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Shehjar Tikoo
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-28 07:13 UTC by Anush Shetty
Modified: 2015-12-01 16:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Anush Shetty 2010-06-28 07:13:47 UTC
io-threads doesn't log its options properly. When the values set are invalid, it is logged though.


       if (dict_get (options, "thread-count")) {
                thread_count = data_to_int32 (dict_get (options,
                                                        "thread-count"));
                if (thread_count < IOT_MIN_THREADS)
                        thread_count = IOT_MIN_THREADS;

                if (thread_count > IOT_MAX_THREADS)
                        thread_count = IOT_MAX_THREADS;
        }
        conf->max_count = thread_count;

        if (dict_get (options, "idle-time")) {
                idle_time = data_to_int32 (dict_get (options,
                                                     "idle-time"));
                if (idle_time < 0)
                        idle_time = 1;
        }
        conf->idle_time = idle_time;

Comment 1 Anand Avati 2010-08-12 04:45:56 UTC
PATCH: http://patches.gluster.com/patch/4082 in master (log added in case of invalid options provided for the io-threads volume)


Note You need to log in before you can comment on or make changes to this bug.