Bug 763118 - (GLUSTER-1386) gnfs nfs3_mknod must handle invalid device type
gnfs nfs3_mknod must handle invalid device type
Status: CLOSED NOTABUG
Product: GlusterFS
Classification: Community
Component: nfs (Show other bugs)
3.1-alpha
All Linux
high Severity low
: ---
: ---
Assigned To: Shehjar Tikoo
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-17 06:08 EDT by Sachidananda Urs
Modified: 2015-12-01 11:45 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: RTNR
Mount Type: nfs
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Sachidananda Urs 2010-08-17 06:08:55 EDT
Dead store  Dead assignment  xlators/nfs/server/src/nfs3.c  2860  1

Refer below url for line number and function name:
http://dev.gluster.com/~raghavendrabhat/2010-07-14-1/report-TWZ0sf.html#EndPath

Shehjar wrote:

@@ -2857,7 +2855,7 @@ nfs3_mknod (rpcsvc_request_t *req, struct nfs3_fh *fh, char *name,
                                                                  &cs->mode);
                break;
        default:
-                ret = -EBADF;
+                /* ret = -EBADF; */
                break;
        }
 

Dont include this line in this patch. Your change has brought out a minor bug in gnfs. I'll send the correct fix for that. Thanks.
Comment 1 Shehjar Tikoo 2010-10-05 04:56:40 EDT
Minor introspection bug. Setting to 3.1.1

Note You need to log in before you can comment on or make changes to this bug.