Bug 763131 (GLUSTER-1399) - posix_readv align to page boundary
Summary: posix_readv align to page boundary
Keywords:
Status: CLOSED DUPLICATE of bug 762821
Alias: GLUSTER-1399
Product: GlusterFS
Classification: Community
Component: posix
Version: mainline
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Vijay Bellur
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-19 08:46 UTC by Sachidananda Urs
Modified: 2015-12-01 16:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Sachidananda Urs 2010-08-19 08:46:01 UTC 
Dead store  Dead assignment  xlators/storage/posix/src/posix.c  2311  1
refer:
http://dev.gluster.com/~raghavendrabhat/2010-07-14-1/report-omo64L.html#EndPath

        if (pfd->flags & O_DIRECT) {
                align = 4096;    /* align to page boundary */
        }

The align is nowhere used later in the function. What is the proper fix?
Comment 1 Amar Tumballi 2010-10-06 09:04:04 UTC 
Removing it. 'align' is no more required in readv as iobuf is properly page aligned. Will be sending a bug fix for it as a part of CLANG report.

*** This bug has been marked as a duplicate of bug 1089 ***
Note You need to log in before you can comment on or make changes to this bug.