PATCH: http://patches.gluster.com/patch/6506 in master (libglusterfs/compat.h: Fix build warning in dirent_size().)

Venky, any updates on this? I saw you submitted set of patches. Can you re-submit them with Shehjar's comments taken in.

Regards,
Amar

I already submitted the patch with shehjar's comments taken in. It's here: http://patches.gluster.com/patch/6684/

(In reply to comment #3)
> I already submitted the patch with shehjar's comments taken in. It's here:
> http://patches.gluster.com/patch/6684/

If I open that link, I can see that its not in a proper format. Can you resubmit the bug without 'Regards,Venky' or mention of 'Shehjar's comments' etc in the commit log?

Thanks.

PATCH: http://patches.gluster.com/patch/6790 in master (build fixes)

as of today (26th May, 2011) below are the warnings:


GlusterFS configure summary
===========================
FUSE client        : yes
Infiniband verbs   : yes
epoll IO multiplex : yes
argp-standalone    : no
fusermount         : no
readline           : yes
georeplication     : yes

amar@supernova:~/work/glusterfs/temp$ make > /dev/null
rpc/rpc-transport/socket/src/socket.c: In function ‘socket_connect’:
rpc/rpc-transport/socket/src/socket.c:1986: warning: dereferencing pointer ‘sockaddr.214’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/socket.c:1986: note: initialized from here
rpc/rpc-transport/socket/src/name.c: In function ‘fill_inet6_inet_identifiers’:
rpc/rpc-transport/socket/src/name.c:625: warning: dereferencing pointer ‘tmpaddr.110’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:625: note: initialized from here
rpc/rpc-transport/socket/src/name.c:626: warning: dereferencing pointer ‘tmpaddr.111’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:626: note: initialized from here
rpc/rpc-transport/socket/src/name.c:627: warning: dereferencing pointer ‘tmpaddr.111’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:627: note: initialized from here
rpc/rpc-transport/socket/src/name.c:631: warning: dereferencing pointer ‘tmpaddr.111’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:631: note: initialized from here
rpc/rpc-transport/socket/src/name.c:637: warning: dereferencing pointer ‘tmpaddr.111’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:637: note: initialized from here
rpc/rpc-transport/socket/src/name.c:640: warning: dereferencing pointer ‘tmpaddr.111’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:640: note: initialized from here
rpc/rpc-transport/socket/src/name.c:657: warning: dereferencing pointer ‘in_ptr’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:656: warning: dereferencing pointer ‘in_ptr’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:655: warning: dereferencing pointer ‘in_ptr’ does break strict-aliasing rules
rpc/rpc-transport/socket/src/name.c:652: note: initialized from here
rpc/rpc-transport/rdma/src/rdma.c: In function ‘rdma_connect’:
rpc/rpc-transport/rdma/src/rdma.c:4538: warning: dereferencing pointer ‘sockaddr.367’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/rdma.c:4538: note: initialized from here
rpc/rpc-transport/rdma/src/rdma.c:4555: warning: dereferencing pointer ‘sockaddr.370’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/rdma.c:4555: note: initialized from here
rpc/rpc-transport/rdma/src/rdma.c: In function ‘rdma_listen’:
rpc/rpc-transport/rdma/src/rdma.c:4735: warning: dereferencing pointer ‘sockaddr.377’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/rdma.c:4735: note: initialized from here
rpc/rpc-transport/rdma/src/name.c: In function ‘fill_inet6_inet_identifiers’:
rpc/rpc-transport/rdma/src/name.c:586: warning: dereferencing pointer ‘tmpaddr.105’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:586: note: initialized from here
rpc/rpc-transport/rdma/src/name.c:593: warning: dereferencing pointer ‘tmpaddr.106’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:593: note: initialized from here
rpc/rpc-transport/rdma/src/name.c:595: warning: dereferencing pointer ‘tmpaddr.106’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:595: note: initialized from here
rpc/rpc-transport/rdma/src/name.c:601: warning: dereferencing pointer ‘tmpaddr.106’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:601: note: initialized from here
rpc/rpc-transport/rdma/src/name.c:609: warning: dereferencing pointer ‘tmpaddr.106’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:609: note: initialized from here
rpc/rpc-transport/rdma/src/name.c:612: warning: dereferencing pointer ‘tmpaddr.106’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:612: note: initialized from here
rpc/rpc-transport/rdma/src/name.c:630: warning: dereferencing pointer ‘in_ptr’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:629: warning: dereferencing pointer ‘in_ptr’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:628: warning: dereferencing pointer ‘in_ptr’ does break strict-aliasing rules
rpc/rpc-transport/rdma/src/name.c:625: note: initialized from here
xlators/nfs/lib/src/rpc-socket.c: In function ‘nfs_rpcsvc_socket_listen’:
xlators/nfs/lib/src/rpc-socket.c:54: warning: dereferencing pointer ‘sockaddr.57’ does break strict-aliasing rules
xlators/nfs/lib/src/rpc-socket.c:88: note: initialized from here
xlators/nfs/lib/src/rpc-socket.c:96: warning: dereferencing pointer ‘sockaddr.57’ does break strict-aliasing rules
xlators/nfs/lib/src/rpc-socket.c:96: note: initialized from here
xlators/mgmt/glusterd/src/glusterd-op-sm.c: In function ‘glusterd_quota_child_waitpid’:
xlators/mgmt/glusterd/src/glusterd-op-sm.c:4856: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result
contrib/apple/daemon.c: In function ‘os_daemon_return’:
contrib/apple/daemon.c:78: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result
amar@supernova:~/work/glusterfs/temp$

nfs3.c: In function 'nfs3_create_exclusive':
nfs3.c:2440: warning: integer constant is too large for 'long' type

PATCH: http://patches.gluster.com/patch/7428 in master (build warning fixes)

With committed patch with

amar@home:~$ gcc --version
gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

GlusterFS code base (other than the one in 'contrib/*') doesn't have any warnings if compiled without a '-g -O0' CFLAGS.

Checking with master  (73eca3be5c5ccc71bbad934338c1ef58ed37c483) ,with gcc
# gcc --version
gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


didn't produce any warnings.
#make > /dev/null

but checking with gcc 4.1.2 

# gcc --version
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-48)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

gives following 
# make > /dev/null
./graph.l: In function 'yylex':
./graph.l:127: warning: label 'find_rule' defined but not used
mem-pool.c: In function '__gf_realloc':
mem-pool.c:206: warning: dereferencing type-punned pointer will break strict-aliasing rules
auth-glusterfs.c: In function 'xdr_auth_glusterfs_parms':
auth-glusterfs.c:57: warning: value computed is not used
auth-glusterfs.c:58: warning: value computed is not used
auth-glusterfs.c:59: warning: value computed is not used
auth-glusterfs.c:60: warning: value computed is not used
auth-glusterfs.c:66: warning: value computed is not used
rpc-common.c: In function 'xdr_gf_prog_detail':
rpc-common.c:92: warning: dereferencing type-punned pointer will break strict-aliasing rules
rpc-common.c: In function 'xdr_gf_dump_rsp':
rpc-common.c:106: warning: dereferencing type-punned pointer will break strict-aliasing rules
rdma.c: In function '__rdma_send_reply_type_nomsg':
rdma.c:1464: warning: dereferencing type-punned pointer will break strict-aliasing rules
rdma.c: In function '__rdma_send_reply_type_msg':
rdma.c:1548: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterfs3-xdr.c: In function 'xdr_gf_iatt':
glusterfs3-xdr.c:101: warning: value computed is not used
glusterfs3-xdr.c:102: warning: value computed is not used
glusterfs3-xdr.c:103: warning: value computed is not used
glusterfs3-xdr.c:104: warning: value computed is not used
glusterfs3-xdr.c:129: warning: value computed is not used
glusterfs3-xdr.c:130: warning: value computed is not used
glusterfs3-xdr.c:131: warning: value computed is not used
glusterfs3-xdr.c:132: warning: value computed is not used
glusterfs3-xdr.c:133: warning: value computed is not used
glusterfs3-xdr.c:134: warning: value computed is not used
glusterfs3-xdr.c: In function 'xdr_gfs3_rchecksum_rsp':
glusterfs3-xdr.c:1287: warning: value computed is not used
glusterfs3-xdr.c:1288: warning: value computed is not used
glusterfs3-xdr.c:1289: warning: value computed is not used
glusterfs3-xdr.c: In function 'xdr_gf_notify_rsp':
glusterfs3-xdr.c:1385: warning: value computed is not used
glusterfs3-xdr.c:1386: warning: value computed is not used
glusterfs3-xdr.c:1387: warning: value computed is not used
glusterfs3-xdr.c: In function 'xdr_gfs3_dirlist':
glusterfs3-xdr.c:1470: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterfs3-xdr.c: In function 'xdr_gfs3_readdir_rsp':
glusterfs3-xdr.c:1482: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterfs3-xdr.c: In function 'xdr_gfs3_dirplist':
glusterfs3-xdr.c:1502: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterfs3-xdr.c: In function 'xdr_gfs3_readdirp_rsp':
glusterfs3-xdr.c:1514: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli1-xdr.c: In function 'xdr_gf1_cli_probe_rsp':
cli1-xdr.c:146: warning: value computed is not used
cli1-xdr.c:147: warning: value computed is not used
cli1-xdr.c:148: warning: value computed is not used
glusterd1-xdr.c: In function 'xdr_gd1_mgmt_stage_op_rsp':
glusterd1-xdr.c:217: warning: value computed is not used
glusterd1-xdr.c:218: warning: value computed is not used
glusterd1-xdr.c:219: warning: value computed is not used
glusterd1-xdr.c: In function 'xdr_gd1_mgmt_commit_op_rsp':
glusterd1-xdr.c:301: warning: value computed is not used
glusterd1-xdr.c:302: warning: value computed is not used
glusterd1-xdr.c:303: warning: value computed is not used
portmap-xdr.c: In function 'xdr_pmap_port_by_brick_rsp':
portmap-xdr.c:55: warning: value computed is not used
portmap-xdr.c:56: warning: value computed is not used
portmap-xdr.c:57: warning: value computed is not used
portmap-xdr.c:58: warning: value computed is not used
portmap-xdr.c: In function 'xdr_pmap_brick_by_port_rsp':
portmap-xdr.c:117: warning: value computed is not used
portmap-xdr.c:118: warning: value computed is not used
portmap-xdr.c:119: warning: value computed is not used
stripe.c: In function 'stripe_aggregate':
stripe.c:247: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/lib/src/libxlator.c: In function 'cluster_markerxtime_cbk':
../../../../xlators/lib/src/libxlator.c:126: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/lib/src/libxlator.c: In function 'cluster_markerxtime_cbk':
../../../../xlators/lib/src/libxlator.c:126: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/lib/src/libxlator.c: In function 'cluster_markerxtime_cbk':
../../../../xlators/lib/src/libxlator.c:126: warning: dereferencing type-punned pointer will break strict-aliasing rules
In file included from dht.c:29:
dht-common.c: In function 'dht_aggregate':
dht-common.c:49: warning: dereferencing type-punned pointer will break strict-aliasing rules
In file included from nufa.c:26:
dht-common.c: In function 'dht_aggregate':
dht-common.c:49: warning: dereferencing type-punned pointer will break strict-aliasing rules
In file included from switch.c:26:
dht-common.c: In function 'dht_aggregate':
dht-common.c:49: warning: dereferencing type-punned pointer will break strict-aliasing rules

quota.c: In function 'quota_validate_cbk':
quota.c:237: warning: dereferencing type-punned pointer will break strict-aliasing rules
quota.c: In function '__quota_init_inode_ctx':
quota.c:537: warning: dereferencing type-punned pointer will break strict-aliasing rules
quota.c: In function 'quota_lookup_cbk':
quota.c:625: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/nfs/lib/src/xdr-nfs3.c: In function 'xdr_entry3':
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1314: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/nfs/lib/src/xdr-nfs3.c: In function 'xdr_dirlist3':
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1322: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/nfs/lib/src/xdr-nfs3.c: In function 'xdr_entryp3':
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1396: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/nfs/lib/src/xdr-nfs3.c: In function 'xdr_dirlistp3':
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1404: warning: dereferencing type-punned pointer will break strict-aliasing rules
../../../../xlators/nfs/lib/src/xdr-nfs3.c: In function 'xdr_pathconf3resok':
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1599: warning: value computed is not used
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1600: warning: value computed is not used
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1601: warning: value computed is not used
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1602: warning: value computed is not used
../../../../xlators/nfs/lib/src/xdr-nfs3.c: In function 'xdr_mountres3_ok':
../../../../xlators/nfs/lib/src/xdr-nfs3.c:1759: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-handler.c: In function 'glusterd_fsm_log_send_resp':
glusterd-handler.c:2632: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-handler.c: In function 'glusterd_op_stage_send_resp':
glusterd-handler.c:2796: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-handler.c: In function 'glusterd_op_commit_send_resp':
glusterd-handler.c:2835: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-handler.c: In function 'glusterd_list_friends':
glusterd-handler.c:3731: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-handler.c: In function 'glusterd_get_volumes':
glusterd-handler.c:3838: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-op-sm.c: In function 'glusterd_brick_op_build_payload':
glusterd-op-sm.c:221: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-op-sm.c:262: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-utils.c: In function 'glusterd_import_volinfo':
glusterd-utils.c:1839: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-rpc-ops.c: In function 'glusterd_op_send_cli_response':
glusterd-rpc-ops.c:203: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-rpc-ops.c:290: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-rpc-ops.c:322: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-rpc-ops.c: In function 'glusterd3_1_friend_add':
glusterd-rpc-ops.c:1423: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-rpc-ops.c: In function 'glusterd3_1_stage_op':
glusterd-rpc-ops.c:1635: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterd-rpc-ops.c: In function 'glusterd3_1_commit_op':
glusterd-rpc-ops.c:1697: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterfsd-mgmt.c: In function ‘glusterfs_terminate_response_send’:
glusterfsd-mgmt.c:179: warning: dereferencing type-punned pointer will break strict-aliasing rules
glusterfsd-mgmt.c: In function ‘glusterfs_translator_info_response_send’:
glusterfsd-mgmt.c:247: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_replace_brick_cbk’:
cli-rpc-ops.c:1136: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_get_volume’:
cli-rpc-ops.c:1739: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_create_volume’:
cli-rpc-ops.c:1773: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c:1784: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_reset_volume’:
cli-rpc-ops.c:2049: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_set_volume’:
cli-rpc-ops.c:2090: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_add_brick’:
cli-rpc-ops.c:2136: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_remove_brick’:
cli-rpc-ops.c:2185: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_replace_brick’:
cli-rpc-ops.c:2237: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c:2280: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_quota’:
cli-rpc-ops.c:2552: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_gsync_set’:
cli-rpc-ops.c:2911: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_profile_volume_cbk’:
cli-rpc-ops.c:3178: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_profile_volume’:
cli-rpc-ops.c:3261: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_top_volume_cbk’:
cli-rpc-ops.c:3343: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c:3353: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c:3427: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c:3431: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c: In function ‘gf_cli3_1_top_volume’:
cli-rpc-ops.c:3478: warning: dereferencing type-punned pointer will break strict-aliasing rules
cli-rpc-ops.c:3484: warning: dereferencing type-punned pointer will break strict-aliasing rules

reopening since it still shows messages with gcc  4.1.2  and changed status from "critical" to "enhancement"

With latest master:


amar@supernova:~/work/glusterfs/build$ make > /dev/null
../../../../rpc/rpc-lib/src/rpcsvc.c: In function ‘rpcsvc_transport_privport_check’:
../../../../rpc/rpc-lib/src/rpcsvc.c:2285: warning: dereferencing pointer ‘sa’ does break strict-aliasing rules
../../../../rpc/rpc-lib/src/rpcsvc.c:2275: note: initialized from here
../../../../../xlators/mgmt/glusterd/src/glusterd-rpc-ops.c: In function ‘glusterd_op_send_cli_response’:
../../../../../xlators/mgmt/glusterd/src/glusterd-rpc-ops.c:60: warning: ‘xdrproc’ may be used uninitialized in this function



One is due to RPC merges from kris, another is variable io-buf support from shishir. Please validate these two, and submit patches.

CHANGE: http://review.gluster.com/371 (This fixes ~200 such warnings, but leaves three categories untouched.) merged in master by Anand Avati (avati)

CHANGE: http://review.gluster.com/378 (Used a #pragma to kill ~170 in rpcgen code.  Added GF_UNUSED to deal with) merged in master by Vijay Bellur (vijay)

CHANGE: http://review.gluster.com/607 (with this patch, there are no more warnings with gcc (GCC) 4.6.1 20110908) merged in master by Anand Avati (avati)

For now we are moving to fedora/RHEL based gcc's. latest master has all the warnings fixed. Lets keep opening new bugs for every new build issue which pops up.

CHANGE: http://review.gluster.com/625 (the current way is very crude method to solve the warning issues with) merged in release-3.2 by Vijay Bellur (vijay)