Bug 764510 (GLUSTER-2778) - sanitize gsyncd logs
Summary: sanitize gsyncd logs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-2778
Product: GlusterFS
Classification: Community
Component: geo-replication
Version: mainline
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Csaba Henk
QA Contact:
URL:
Whiteboard:
: GLUSTER-2920 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-04-15 16:37 UTC by Csaba Henk
Modified: 2012-05-19 12:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: RTNR
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Csaba Henk 2011-04-15 16:37:01 UTC 
It's overly verbose, should be cut back to not to repeat iteratedly redundant information.
Comment 1 Csaba Henk 2011-05-21 14:44:44 UTC 
*** Bug 2920 has been marked as a duplicate of this bug. ***
Comment 2 Vikas Gorur 2011-06-09 15:23:13 UTC 
Also, detect two common cases:

1) SSH key not valid / not present. Currently this shows up as an uncaught EOFError.

2) SSH connection broken in the middle. Currently this shows up as an uncaught pickling error.
Comment 3 Csaba Henk 2011-06-13 06:56:11 UTC 
(In reply to comment #2)
> Also, detect two common cases:
> 
> 1) SSH key not valid / not present. Currently this shows up as an uncaught
> EOFError.
> 
> 2) SSH connection broken in the middle. Currently this shows up as an uncaught
> pickling error.

Vikas, I'm afraid this information cannot really be used for improving logs, because you can't imply back from EOFError to an ssh key issue. (They still might be useful for narrowing down the spectrum on debugging.)
Comment 4 Vikas Gorur 2011-06-13 14:03:52 UTC 
> Vikas, I'm afraid this information cannot really be used for improving logs,
> because you can't imply back from EOFError to an ssh key issue. (They still
> might be useful for narrowing down the spectrum on debugging.)

I know EOFError does not imply missing ssh key. However, not having the ssh key present is one of the most common error scenarios, and it needs to be somehow identified and reported in the logs.
Comment 5 Anand Avati 2011-07-28 06:57:20 UTC 
CHANGE: http://review.gluster.com/80 (Change-Id: I19f6cf539289062b39e3c0f73fa88f4ff9488349) merged in master by Anand Avati (avati)
Comment 6 Anand Avati 2011-07-28 06:58:48 UTC 
CHANGE: http://review.gluster.com/82 (Change-Id: Iedd8c0ce9dec2d8dcb01e0e5b409cb53185b1716) merged in master by Anand Avati (avati)
Comment 7 Anand Avati 2011-07-28 07:01:22 UTC 
CHANGE: http://review.gluster.com/83 (Change-Id: I4317e60fce3280c45dbcc4a5f233a4344aba9500) merged in master by Anand Avati (avati)
Comment 8 Anand Avati 2011-07-29 07:29:27 UTC 
CHANGE: http://review.gluster.com/81 (Change-Id: I5c5211858bdb2bd28324818362d95edd97f94207) merged in master by Anand Avati (avati)
Comment 9 Anand Avati 2011-07-29 09:24:45 UTC 
CHANGE: http://review.gluster.com/125 (- exceptions raised by us will be logged as single-line error messages) merged in master by Anand Avati (avati)
Comment 10 Anand Avati 2012-04-13 07:25:54 UTC 
CHANGE: http://review.gluster.com/3113 (geo-rep / gsyncd: log sync failures as warnings) merged in master by Vijay Bellur (vijay)
Comment 11 Anand Avati 2012-05-19 12:45:45 UTC 
CHANGE: http://review.gluster.com/3078 (geo-rep / gsyncd: recognize ECONNABORTED as termination of aux glusterfs) merged in master by Vijay Bellur (vijay)
Note You need to log in before you can comment on or make changes to this bug.