While reviewing code, found that 'cli_out()' doesn't check for format errors during the compile time. Added a check like 'gf_log()' and the result is below.


../../../cli/src/cli-cmd-volume.c: In function ‘cli_cmd_volume_stop_cbk’:
../../../cli/src/cli-cmd-volume.c:397: warning: too many arguments for format
../../../cli/src/cli-cmd-volume.c: In function ‘cli_cmd_volume_rename_cbk’:
../../../cli/src/cli-cmd-volume.c:453: warning: too many arguments for format
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_get_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:461: warning: zero-length gnu_printf format string
../../../cli/src/cli-rpc-ops.c:505: warning: too many arguments for format
../../../cli/src/cli-rpc-ops.c:598: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_delete_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:688: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_stop_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:785: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_defrag_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:834: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:843: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:856: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_log_filename_cbk’:
../../../cli/src/cli-rpc-ops.c:1225: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_log_rotate_cbk’:
../../../cli/src/cli-rpc-ops.c:1284: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_sync_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:1316: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_log_level_cbk’:
../../../cli/src/cli-rpc-ops.c:2316: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_fsm_log_cbk’:
../../../cli/src/cli-rpc-ops.c:2583: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘cmd_profile_volume_brick_out’:
../../../cli/src/cli-rpc-ops.c:3029: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:3030: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:3031: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:3032: warning: zero-length gnu_printf format string
../../../cli/src/cli-rpc-ops.c:3047: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:3048: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:3049: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c:3069: warning: zero-length gnu_printf format string
../../../cli/src/cli-rpc-ops.c:3073: warning: zero-length gnu_printf format string
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_profile_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:3128: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_top_volume_cbk’:
../../../cli/src/cli-rpc-ops.c:3259: warning: format not a string literal and no format arguments
../../../cli/src/cli-rpc-ops.c: In function ‘gf_cli3_1_getwd_cbk’:
../../../cli/src/cli-rpc-ops.c:3455: warning: format not a string literal and no format arguments