Bug 764718 (GLUSTER-2986) - Failed operations should should be logged `E' or `W'
Summary: Failed operations should should be logged `E' or `W'
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-2986
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-03 10:18 UTC by Sachidananda Urs
Modified: 2011-07-25 07:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Sachidananda Urs 2011-06-03 10:18:17 UTC 
Failed operations like:

==============================
[2011-06-03 15:26:22.988017] I [afr-self-heal-entry.c:1088:afr_sh_entry_impunge_newfile_cbk] 0-dist-rep-replicate-0: creation of /xaaaabm on dist-rep-client-1 failed (Read-only file system)
[2011-06-03 15:26:22.988065] I [client3_1-fops.c:232:client3_1_mknod_cbk] 0-dist-rep-client-1: remote operation failed: Read-only file system
[2011-06-03 15:26:22.988076] I [afr-self-heal-entry.c:1088:afr_sh_entry_impunge_newfile_cbk] 0-dist-rep-replicate-0: creation of /xaaaacs on dist-rep-client-1 failed (Read-only file system)
[2011-06-03 15:26:22.988174] I [client3_1-fops.c:232:client3_1_mknod_cbk] 0-dist-rep-client-1: remote operation failed: Read-only file system
[2011-06-03 15:26:22.988185] I [afr-self-heal-entry.c:1088:afr_sh_entry_impunge_newfile_cbk] 0-dist-rep-replicate-0: creation of /xaaaacf on dist-rep-client-1 failed (Read-only file system)
[2011-06-03 15:26:22.988235] I [client3_1-fops.c:232:client3_1_mknod_cbk] 0-dist-rep-client-1: remote operation failed: Read-only file system
[2011-06-03 15:26:22.988246] I [afr-self-heal-entry.c:1088:afr_sh_entry_impunge_newfile_cbk] 0-dist-rep-replicate-0: creation of /xaaaabv on dist-rep-client-1 failed (Read-only file system)
[2011-06-03 15:26:22.988268] I [client3_1-fops.c:232:client3_1_mknod_cbk] 0-dist-rep-client-1: remote operation failed: Read-only file system
===================================

Should be logged `E' or `W', this helps in recognizing failures easily by grep'ing for Errors or Warnings...
Comment 1 Amar Tumballi 2011-06-03 10:49:38 UTC 
The reason why these are 'INFO' logs and not Warning or Error logs is because as long as a error is passed through FUSE or NFS, we can't classify it as a Error to Users. Also that we don't want to fill in lot of logs in Warning / Error level without being absolutely sure about it.

We can sit again and finalize on these things so we can get all the things get done in 3.3.x version.
Comment 2 Anand Avati 2011-06-08 07:03:00 UTC 
PATCH: http://patches.gluster.com/patch/7374 in master (protocol/client: Change log level of error to GF_LOG_ERROR)
Comment 3 Anand Avati 2011-06-08 07:03:06 UTC 
PATCH: http://patches.gluster.com/patch/7375 in master (cluster/afr: Log errors in afr self-heal with GF_LOG_ERROR)
Comment 4 Anand Avati 2011-06-08 07:03:12 UTC 
PATCH: http://patches.gluster.com/patch/7376 in release-3.2 (protocol/client: Change log level of error to GF_LOG_ERROR)
Comment 5 Anand Avati 2011-06-08 07:03:18 UTC 
PATCH: http://patches.gluster.com/patch/7377 in release-3.2 (cluster/afr: Log errors in afr self-heal with GF_LOG_ERROR)
Comment 6 Anand Avati 2011-06-09 11:41:32 UTC 
PATCH: http://patches.gluster.com/patch/7445 in release-3.1 (cluster/afr: Log errors in afr self-heal with GF_LOG_ERROR)
Comment 7 Raghavendra Bhat 2011-07-25 04:00:20 UTC 
Failed operations are now either WARNING or ERROR messages.
Note You need to log in before you can comment on or make changes to this bug.