Bug 765553 (GLUSTER-3821) - call cli_cmd_unlock in the same function as cli_cmd_lock
Summary: call cli_cmd_unlock in the same function as cli_cmd_lock
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-3821
Product: GlusterFS
Classification: Community
Component: cli
Version: pre-release
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
Assignee: Amar Tumballi
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-21 10:17 UTC by Niels de Vos
Modified: 2013-12-19 00:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2011-11-21 10:17:41 UTC
cli_cmd_submit calls cli_cmd_lock, but cli_cmd_unlock is done in
cli_cmd_await_response. It is clearer to do the locking and unlocking in
the same function.

Only cli_cmd_submit seems to call cli_cmd_await_response, therefore
moving the cli_cmd_unlock to cli_cmd_submit should be safe.

Vijay Bellur requested to open a bug: http://review.gluster.com/721

Comment 1 Anand Avati 2011-11-23 09:06:32 UTC
CHANGE: http://review.gluster.com/721 (cli_cmd_submit calls cli_cmd_lock, but cli_cmd_unlock is done in) merged in master by Vijay Bellur (vijay)


Note You need to log in before you can comment on or make changes to this bug.