Bug 767226 - Review Request: scannotation - A Java annotation scanner
Summary: Review Request: scannotation - A Java annotation scanner
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-13 15:08 UTC by Kashyap Chamarthy
Modified: 2012-01-11 06:01 UTC (History)
5 users (show)

Fixed In Version: scannotation-1.0.3-0.2.r12.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-11 06:01:25 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Kashyap Chamarthy 2011-12-13 15:08:58 UTC
SPEC: http://10.65.201.157/rpmbuild/SPECS/scannotation.spec

SRPM: http://kashyapc.fedorapeople.org/srpms/scannotation-1.0.3-0.1.r12.fc17.src.rpm

Description:

Scannotation is a Java library that creates an annotation database 
from a set of .class files.This database is really just a set of maps that index
what annotations are used and what classes are using them. Why do you need this? 
What if you are an annotation framework like an EJB 3.0 container and you want 
to automatically scan your classpath for EJB annotations so that you know what 
to deploy? Scannotation gives you apis that allow you to find archives in your 
classpath or WAR (web application) that you want to scan, then automatically 
scans them without loading each and every class within those archives

Comment 1 Kashyap Chamarthy 2011-12-13 15:10:50 UTC
1/ rpmlint warnings (All of them seem to be benign warnings)

###############
[build@dhcp201-157 SPECS]$ rpmlint scannotation.spec  ../RPMS/noarch/scannotation-* ../SRPMS/scannotation-1.0.3-0.1.r12.fc17.src.rpm 
scannotation.spec: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz
scannotation.noarch: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate
scannotation.noarch: W: spelling-error %description -l en_US apis -> pis, apish, apes
scannotation-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
scannotation.src: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate
scannotation.src: W: spelling-error %description -l en_US apis -> pis, apish, apes
scannotation.src: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz
3 packages and 1 specfiles checked; 0 errors, 7 warnings.
[build@dhcp201-157 SPECS]$ 
###############

2/ Successful koji scratch build -- 

http://koji.fedoraproject.org/koji/taskinfo?taskID=3582272

Comment 2 Kashyap Chamarthy 2011-12-14 08:34:59 UTC
(In reply to comment #0)
> SPEC: http://10.65.201.157/rpmbuild/SPECS/scannotation.spec

Sorry, correct 'SPEC' URL location is here:

http://kashyapc.fedorapeople.org/spec-files/scannotation.spec
> 
> SRPM:
> http://kashyapc.fedorapeople.org/srpms/scannotation-1.0.3-0.1.r12.fc17.src.rpm
> 
> Description:
> 
> Scannotation is a Java library that creates an annotation database 
> from a set of .class files.This database is really just a set of maps that
> index
> what annotations are used and what classes are using them. Why do you need
> this? 
> What if you are an annotation framework like an EJB 3.0 container and you want 
> to automatically scan your classpath for EJB annotations so that you know what 
> to deploy? Scannotation gives you apis that allow you to find archives in your 
> classpath or WAR (web application) that you want to scan, then automatically 
> scans them without loading each and every class within those archives

Comment 3 Parag AN(पराग) 2011-12-14 09:26:56 UTC
Review:
+ koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3582272

+ Source generated from svn revision 12 so no verification with upstream here

+ rpmlint on rpms gave
scannotation.noarch: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate
scannotation.noarch: W: spelling-error %description -l en_US apis -> pis, apish, apes
scannotation.src: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate
scannotation.src: W: spelling-error %description -l en_US apis -> pis, apish, apes
scannotation.src: W: invalid-url Source0: scannotation-1.0.3.Final.tar.xz
scannotation-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ rest looks ok in specfile

Suggestions:
1) you should preserve the timestamps of files being installed using -p. so replace
cp %SOURCE1 .
with 
cp -p %SOURCE1 .

APPROVED.

Comment 4 Kashyap Chamarthy 2011-12-14 11:49:17 UTC
Thanks Parag for the review. Modified spec and rebuilt SRPM.

Updated SPEC and SRPM here:

SPEC: http://kashyapc.fedorapeople.org/spec-files/scannotation.spec

SRPM: http://kashyapc.fedorapeople.org/srpms/scannotation-1.0.3-0.2.r12.fc17.src.rpm

Comment 5 Kashyap Chamarthy 2011-12-14 12:09:55 UTC
New Package SCM Request
=======================
Package Name: scannotation
Short Description: A Java annotation scanner
Owners: vakwetu kashyapc
Branches: f16 f17
InitialCC: goldmann

Comment 6 Gwyn Ciesla 2011-12-14 13:10:38 UTC
Git done (by process-git-requests).

Did not grant access to vakwetu, not in packager group.
Did not create f17 branch, f17==devel.

Comment 7 Kashyap Chamarthy 2011-12-14 13:20:05 UTC
Jon, can you provide access to 'goldmann' too please ?

Comment 8 Fedora Update System 2011-12-19 17:27:38 UTC
scannotation-1.0.3-0.2.r12.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/scannotation-1.0.3-0.2.r12.fc16

Comment 9 Fedora Update System 2011-12-22 22:51:11 UTC
scannotation-1.0.3-0.2.r12.fc16 has been pushed to the Fedora 16 testing repository.

Comment 10 Fedora Update System 2012-01-11 06:01:25 UTC
scannotation-1.0.3-0.2.r12.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.