I appended 2 patches, one for module and the other for oprofile 0.3.
Created attachment 82105 [details] Support oprofile module
Created attachment 82106 [details] Upgrade to oprofile 0.3
exporting the sys_call_table is not an option; it actually makes oprofile unsafe to use ;(
the real fix is to backport the 2.5 version that doesn't need this export...
Do you have a testcase to show the sys_call_table problem? I haven't noticed any yet.
sure load oprofile. load vtune. stop oprofile, unload module stop vtune BOOM both oprofile and vtune would stack on the same syscalls... but only save the last one.
Are you implying making oprofile builtin makes it safe? If it is true, I have one line change to disable unloading oprofile.
not making the syscall table available to modules makes it safe eg there is only going to be exactly 1 thing that can muck about with it and that is oprofile
I can live with that if I have to make a choice. I need oprofile on UP kernel and it is disabled. The worst can happen is I have to remember I can only use oprofile or vtune at a time. I don't even know/use vtune, which I assume has something to do with VTune from Intel.
the reason oprofile is disabled on UP is because it unconditially enabled the apic... which breaks several laptops we're trying to fix THAT and then it'll be on in the UP kernel again
Thanks for the bug report. However, Red Hat no longer maintains this version of the product. Please upgrade to the latest version and open a new bug if the problem persists. The Fedora Legacy project (http://fedoralegacy.org/) maintains some older releases, and if you believe this bug is interesting to them, please report the problem in the bug tracker at: http://bugzilla.fedora.us/