Bug 768399 - Options Format File is not applied to command line prompts
Summary: Options Format File is not applied to command line prompts
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Katello
Classification: Retired
Component: Installer
Version: 1.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 1.0
Assignee: Lukas Zapletal
QA Contact: Katello QA List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-16 15:03 UTC by Bryan Kearney
Modified: 2012-07-17 13:09 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-17 13:09:38 UTC

Attachments (Terms of Use)
proposed patch (1.11 KB, text/plain)
2012-01-09 12:22 UTC, Tomas Lestach 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Bryan Kearney 2011-12-16 15:03:03 UTC 
I added this line to the file in /usr/share/katello/install/options-format-file.

# deployment types
deployment                  true   [headpin|katello]


It will catch errors in the default answer file. For example, if I set deploymnet=Fred. However, if leave the default file unchanged and I do this:

katello-confgure --deployment fred

I do not get an error. I would have expected an error to be raised.
Comment 1 Tomas Lestach 2012-01-09 12:22:26 UTC 
Created attachment 551548 [details]
proposed patch
Comment 2 Tomas Lestach 2012-01-09 12:22:53 UTC 
I assume, you've meant to use (headpin|katello) instead of [headpin|katello].
To work the reg exp as expected I'd recommend to use:

deployment                  true   ^(headpin|katello)$


However, there's a misbehavior. I'm attaching a patch, that fixes the default value check.
Comment 3 Lukas Zapletal 2012-04-02 13:47:12 UTC 
Pushing upstream, thanks Tomas!

1f7b670 768399 - deployment configure values are checked
Comment 4 Bryan Kearney 2012-07-17 13:09:38 UTC 
Moving all community bugs with fixes to closed.
Note You need to log in before you can comment on or make changes to this bug.