Bug 769823 - Lock mechanism - for integration tracking
Summary: Lock mechanism - for integration tracking
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: unspecified
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
: ---
Assignee: mkublin
QA Contact: Haim
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-12-22 12:14 UTC by mkublin
Modified: 2014-01-13 00:50 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-11 10:50:45 UTC
oVirt Team: ---


Attachments (Terms of Use)
Patch (16.35 KB, patch)
2011-12-22 12:15 UTC, mkublin
no flags Details | Diff
Storage patch (33.48 KB, patch)
2011-12-28 12:19 UTC, mkublin
no flags Details | Diff
Storage patch Correct One (34.11 KB, patch)
2011-12-28 12:32 UTC, mkublin
no flags Details | Diff

Description mkublin 2011-12-22 12:14:24 UTC
Hi, the following bug is opened in order to perform a tracking for integration team.

It will track different checks which are done for new locking mechanism in engine.

First stage is:

The changes are the following:
 1. Replace default lock mechanism
 2. Some small updates in ActivateStorageDomain, RemoveVM,
 AddStoragePoolWithStoragesCommand

 Please recheck that following change did not cause to regression in the
 following scenario and in general .

(It is also describe at pre-integration ticket: https://trac.qa.lab.tlv.redhat.com/trac/integration/ticket/557)

Comment 1 mkublin 2011-12-22 12:15:11 UTC
Created attachment 549182 [details]
Patch

Comment 2 Haim 2011-12-27 09:39:50 UTC
Testing progress:
- create pool
- create storage domain
- create vm
- create volume
- move vm from one storage to another - null pointer exception
  * http://pastebin.test.redhat.com/71971
- create vm from template (clone) - null pointer exception:
  * http://pastebin.test.redhat.com/71973
- migrate master domain
- migrate master with restarting vdsm on spm host
- suspend 
- create snapshot 
- preview 
- commit 
- delete snapshot (merge)
- multiple actions:
  * delete template & from different session create vm from template
  * activate storage domain & from different session detach storage domain 
  * suspend vm and from different session take vm down 
  * move vm and from different session delete vm

locking mechanism works as expected.

Comment 3 mkublin 2011-12-28 12:19:49 UTC
Created attachment 549818 [details]
Storage patch

Comment 4 mkublin 2011-12-28 12:20:11 UTC
A new patch should introduce an using of lock util inside storage flows.
Please check different storage scenarious, including fail over , sententious creation, attaching, removing, reconstruct etc on storage

Comment 5 mkublin 2011-12-28 12:32:00 UTC
Created attachment 549819 [details]
Storage patch Correct One

Comment 6 mkublin 2011-12-28 12:32:25 UTC
Please use a last storage patch a previous one missing one file

Comment 7 mkublin 2012-01-31 07:37:24 UTC
I think you missed a negative test, like when you try to create a snapshot and failed on CanDoAction and lock was not released and possible any other similar scenarious

Comment 8 mkublin 2012-06-11 10:50:45 UTC
The process was changed again no need for bug


Note You need to log in before you can comment on or make changes to this bug.