Hide Forgot
Description of problem: few string are broken Version-Release number of selected component (if applicable): glibc-common-2.14.90-21.x86_64 How reproducible: everytime Steps to Reproduce: 1. decode locale from unicode to actual character 2. 3. Actual results: some strings are broken with invalid characters for kashmiri Expected results: string should be not broken Additional info: i will give patch for this
I'm going to need a testcase for this.
Created attachment 550351 [details] attached kashmiri decoded file using show-ucs-data.c present in localedata folder of glibc In % Full weekday names (%A) day "आथ््वार्";/ it should be "आथवार्" "चन्द्रवार्";/ "बोम्वारी्";/ it should be "बोम्वारी" "बोघवारी्";/ it should be "बोघवारी" "ब्रस््वार्";/ it should be "ब्रसवार्" "जुमाह्";/ "बटवार्" - dotted circle represent broken string.
Hi Rakesh, आथवार्, "बोम्वारी", "बोघवारी" and ब्रसवार्" are these weekday names are correct, is yes i can prepare patch for this.
i think you might be need U+200d, instead of twice U+094d
(In reply to comment #4) > i think you might be need U+200d, instead of twice U+094d Except these two everything is fine. बोम्वारी should be बोम्वार् बोघवारी should be बोघवार् Regards,
Created attachment 560215 [details] ks locale patch against git glibc Hi Jeff, I have attached a patch. It is against latest git upstream. Cross checked changes and week days seem fine now. @Pravin & Jeff Should I send it to upstream separately ? Regards,
(In reply to comment #6) > (In reply to comment #4) > > i think you might be need U+200d, instead of twice U+094d > > Except these two everything is fine. > > बोम्वारी should be बोम्वार् > बोघवारी should be बोघवार् > > Regards, After discussion with Pravin two more corrections need to be made (circle is a rendering issue). 2 halents are not allowed. आथ््वार् should be आथ्वार् and ब्रस््वार् it should be ब्रस्वार् in addition to above two. Updating the patch.
Created attachment 560440 [details] ks locale patch against git glibc (latest)
Hi Rakesh, tested patch, it resolves mentioned issue. Thank you very much for patch :) Yes, reporting this to upstream will be good.
Yes, please report this upstream. libc-locales.com would be the appropriate place. While I could forward it myself, if there are any questions I'm simply not capable of answering them for this change. Since it looks like the two of you are the original authors of that locale, I'm going to assume your change will ultimately get accepted upstream. In the mean time I'll go ahead and include it in Fedora rawhide.