Bug 771295 - Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now
Summary: Review Request: rubygem-delorean - lets you travel in time with Ruby by mocki...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-03 07:35 UTC by Bohuslav "Slavek" Kabrda
Modified: 2012-01-03 14:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-03 14:20:57 UTC
Type: ---
Embargoed:
vondruch: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Bohuslav "Slavek" Kabrda 2012-01-03 07:35:44 UTC 
Delorean lets you travel in time with Ruby by mocking Time.now.

SPEC: http://bkabrda.fedorapeople.org/pkgs/delorean/rubygem-delorean.spec
SRPM: http://bkabrda.fedorapeople.org/pkgs/delorean/rubygem-delorean-1.2.0-1.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3615002
Comment 1 Vít Ondruch 2012-01-03 12:06:05 UTC 
I'll take it for a review.
Comment 2 Vít Ondruch 2012-01-03 12:55:25 UTC 
* Test suite
  - Please consider execution of the test suite in the %check section? It seems
    there are specs available upstream.

* rpmlint output
  - rpmlint complains about permissions of .spec file:

    rubygem-delorean.src: W: strange-permission rubygem-delorean.spec 0666L
    A file that you listed to include in your package has strange permissions.
    Usually, a file should have 0644 permissions.

Otherwise, I have no other comments, so I APPROVE the package. Please fix the rpmlint before import of the package and consider execution of the test suite.
Comment 3 Bohuslav "Slavek" Kabrda 2012-01-03 13:05:08 UTC 
Thank you for your review. I'll fix these things before making a SCM request.
Comment 4 Bohuslav "Slavek" Kabrda 2012-01-03 13:41:21 UTC 
New Package SCM Request
=======================
Package Name: rubygem-delorean
Short Description: Delorean lets you travel in time with Ruby by mocking Time.now
Owners: bkabrda
Branches: 
InitialCC:
Comment 5 Gwyn Ciesla 2012-01-03 13:49:05 UTC 
Git done (by process-git-requests).
Note You need to log in before you can comment on or make changes to this bug.