Bug 771842 - Review Request: navilu-fonts - Free Kannada Opentype sans-serif font
Summary: Review Request: navilu-fonts - Free Kannada Opentype sans-serif font
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-05 08:14 UTC by Pravin Satpute
Modified: 2012-01-10 07:13 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-10 07:13:11 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Parag AN(पराग) 2012-01-06 08:30:35 UTC
Review:

+ koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3621205

+ rpmlint on rpms gave
 navilu-fonts.noarch: W: spelling-error Summary(en_US) opentype -> open type, open-type, phenotype
navilu-fonts.noarch: W: spelling-error %description -l en_US opentype -> open type, open-type, phenotype
navilu-fonts.src: W: spelling-error Summary(en_US) opentype -> open type, open-type, phenotype
navilu-fonts.src: W: spelling-error %description -l en_US opentype -> open type, open-type, phenotype
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ source verified with upstream as (sha1sum)
eb71807bdfcc479ad5eac07d18da82100a2fd349  navilu-1.1.tar.gz
eb71807bdfcc479ad5eac07d18da82100a2fd349  ../SOURCES/navilu-1.1.tar.gz

+ follows fonts packaging guidelines


Suggestions
1) you should drop the versioned dependency. Change
BuildRequires: fontforge >= 20080429
to
BuildRequires: fontforge

2)you don't need to clean buildroot now. remove following from spec
BuildRequires: fontforge >= 20080429


APPROVED.

Comment 2 Pravin Satpute 2012-01-09 07:31:32 UTC
Thank you Parag for review, i will do the suggested changes during git import.

New Package SCM Request
=======================
Package Name: navilu-fonts
Short Description: Free Kannada Opentype sans-serif font
Owners: pravins
Branches: f16
InitialCC: i18n-team

Comment 3 Gwyn Ciesla 2012-01-09 13:08:23 UTC
Git done (by process-git-requests).

Comment 4 Pravin Satpute 2012-01-10 07:13:11 UTC
Thanks Jon for Git process. done built for rawhide and F16


Note You need to log in before you can comment on or make changes to this bug.