Spec URL: http://goldmann.fedorapeople.org/package_review/staxmapper/1/staxmapper.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/staxmapper/1/staxmapper-1.0.0-1.fc17.src.rpm Description: StAX Mapper Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3622377
I'll look at this one
The rpmlint output (below) is not a problem. Checksums match: c8a96ed55cc375611355741ac8b60e56c089ecb1108ad72084a0dc70a526c144 staxmapper-1.0.0.Final.tar.xz c8a96ed55cc375611355741ac8b60e56c089ecb1108ad72084a0dc70a526c144 /home/mef3/rpmbuild/SOURCES/staxmapper-1.0.0.Final.tar.xz The one other thing that fedora-review picked up is this: [!]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. For me this isn't a showstopper, since this seems to be a jboss subpackage. APPROVED (and hooray for fedora-review! :) ) Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint staxmapper-javadoc-1.0.0-1.fc18.noarch.rpm staxmapper-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint staxmapper-1.0.0-1.fc18.noarch.rpm staxmapper.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint staxmapper-1.0.0-1.fc18.src.rpm staxmapper.src: W: invalid-url Source0: staxmapper-1.0.0.Final.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [!]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. ==== Java ==== [x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Javadoc documentation files are generated and included in -javadoc subpackage [x]: MUST Javadoc subpackages have Requires: jpackage-utils [x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: SHOULD Package has BuildArch: noarch (if possible) [x]: SHOULD Package uses upstream build method (ant/maven/etc.) ==== Maven ==== [x]: MUST Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [x]: MUST Old add_to_maven_depmap macro is not being used [x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro [x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun [x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms Issues: [!]: MUST Rpmlint output is silent. rpmlint staxmapper-javadoc-1.0.0-1.fc18.noarch.rpm staxmapper-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint staxmapper-1.0.0-1.fc18.noarch.rpm staxmapper.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint staxmapper-1.0.0-1.fc18.src.rpm staxmapper.src: W: invalid-url Source0: staxmapper-1.0.0.Final.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Generated by fedora-review 0.1.2 External plugins:
Thank you! New Package SCM Request ======================= Package Name: staxmapper Short Description: StAX Mapper Owners: goldmann Branches: f17
Git done (by process-git-requests).
Thanks for git, closing!