Bug 773144 - inconsistent description in rhc-ctl-domain help page
Summary: inconsistent description in rhc-ctl-domain help page
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: oc
Version: 1.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Abhishek Gupta
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-11 04:28 UTC by Meng Bo
Modified: 2012-02-02 23:56 UTC (History)
1 user (show)

Fixed In Version: rhc-0.85.2-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-02 23:56:01 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Meng Bo 2012-01-11 04:28:44 UTC
Description of problem:
user can perform the command without the required option '-l'

Version-Release number of selected component (if applicable):
rhc-0.84.9-1.el6_2.noarch 

How reproducible:
always

Steps to Reproduce:
1.install latest rhc client
2.check rhc-ctl-domain help
# rhc-ctl-domain -h
  
Actual results:
-l|--rhlogin         rhlogin      Red Hat login (RHN or OpenShift login with OpenShift Express access) (required)

Expected results:
remove the (required) for -l option from the help doc

Additional info:

Comment 1 Alex Boone 2012-01-11 16:18:09 UTC
This is actually consistent with the other commands (they all show that -l is required).  However, it's true that it's possible to omit the -l flag if you have specified a default_rhlogin in your express.conf file.

Comment 2 Abhishek Gupta 2012-01-11 18:01:32 UTC
Refer Alex's comments above. In my opinion, this is not a bug.

Comment 3 Meng Bo 2012-01-12 02:56:39 UTC
Rechecked again, the situation isas following:
1).When there is default_rhlogin defined in express.conf, other commands will not show (required) for the -l option but show (default: bmeng), expect rhc-create-domain and rhc-ctl-domain.
2).When there is no default_rhlogin defined in express.conf, all the commands will show (required) for -l option.

And for the rhc-create-domain command, option -l is required exactly.
So I think this should be fixed.

Comment 4 Abhishek Gupta 2012-01-12 18:38:46 UTC
I have made the required changes to the two commands and will check them in next week.

Comment 5 Abhishek Gupta 2012-01-16 16:40:16 UTC
The changes have been checked into master.

Comment 6 Meng Bo 2012-01-18 08:28:26 UTC
verified with rhc-0.85.2-1.el6_2.noarch,
issue has been fixed.

Comment 7 Mrunal Patel 2012-02-02 23:56:01 UTC
Closing verified bugs.


Note You need to log in before you can comment on or make changes to this bug.