Hide Forgot
Spec URL: http://averi.fedorapeople.org/RPMs/trac-batchmodify-plugin/trac-batchmodify-plugin.spec SRPM URL: http://averi.fedorapeople.org/RPMs/trac-batchmodify-plugin/trac-batchmodify-plugin-0.8.0-20120111svn11133.fc16.src.rpm Description: A trac plugin that allows users to modify several tickets together in one shot. CCing Kevin as requested.
I'll review this. Look for a full review hopefully later today.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Might be good to ask upstream to be more clear about the license and include a copy of it. Not a blocker. 2. rpmlint says: trac-batchmodify-plugin.noarch: W: no-documentation trac-batchmodify-plugin.src: W: invalid-url Source0: trac-batchmodify-plugin-0.8.0.svn11133.tar.gz both can be ignored. I see no blockers here, so this package is APPROVED. Happy to co-maintain.
New Package SCM Request ======================= Package Name: trac-batchmodify-plugin Short Description: Trac's plugin for modifying tickets in batches. Owners: averi kevin Branches: f16 el6 InitialCC: averi kevin
Git done (by process-git-requests).
trac-batchmodify-plugin-0.8.0-20120111svn11133.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-batchmodify-plugin-0.8.0-20120111svn11133.el6
trac-batchmodify-plugin-0.8.0-20120111svn11133.el6 has been pushed to the Fedora EPEL 6 testing repository.
Shall we push this to stable now?
trac-batchmodify-plugin-0.8.0-20120111svn11133.el6 has been pushed to the Fedora EPEL 6 stable repository.