Bug 773487 - Review Request: trac-batchmodify-plugin - Batch modification of tickets
Summary: Review Request: trac-batchmodify-plugin - Batch modification of tickets
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2012-01-11 23:12 UTC by Andrea Veri
Modified: 2013-04-23 02:59 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2013-04-23 02:59:26 UTC
Type: ---
kevin: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Andrea Veri 2012-01-11 23:12:47 UTC
Spec URL: http://averi.fedorapeople.org/RPMs/trac-batchmodify-plugin/trac-batchmodify-plugin.spec
SRPM URL: http://averi.fedorapeople.org/RPMs/trac-batchmodify-plugin/trac-batchmodify-plugin-0.8.0-20120111svn11133.fc16.src.rpm
Description: A trac plugin that allows users to modify several tickets together in one shot.

CCing Kevin as requested.

Comment 1 Kevin Fenzi 2012-01-21 19:47:33 UTC
I'll review this. Look for a full review hopefully later today.

Comment 2 Kevin Fenzi 2012-01-22 00:54:35 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.


OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin


1. Might be good to ask upstream to be more clear about the license and include 
a copy of it. Not a blocker. 

2. rpmlint says: 
trac-batchmodify-plugin.noarch: W: no-documentation
trac-batchmodify-plugin.src: W: invalid-url Source0: trac-batchmodify-plugin-0.8.0.svn11133.tar.gz

both can be ignored. 

I see no blockers here, so this package is APPROVED. 

Happy to co-maintain.

Comment 3 Andrea Veri 2012-01-22 18:25:48 UTC
New Package SCM Request
Package Name: trac-batchmodify-plugin
Short Description: Trac's plugin for modifying tickets in batches.
Owners: averi kevin
Branches: f16 el6
InitialCC: averi kevin

Comment 4 Gwyn Ciesla 2012-01-23 13:08:30 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2012-01-25 14:32:15 UTC
trac-batchmodify-plugin-0.8.0-20120111svn11133.el6 has been submitted as an update for Fedora EPEL 6.

Comment 6 Fedora Update System 2012-01-25 18:53:07 UTC
trac-batchmodify-plugin-0.8.0-20120111svn11133.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 7 Kevin Fenzi 2013-02-03 02:51:08 UTC
Shall we push this to stable now?

Comment 8 Fedora Update System 2013-04-23 02:59:27 UTC
trac-batchmodify-plugin-0.8.0-20120111svn11133.el6 has been pushed to the Fedora EPEL 6 stable repository.

Note You need to log in before you can comment on or make changes to this bug.