Hide Forgot
project_key: SOA JBossTS TransactionReaper contains a bug which results in the reaper executing continuously within dynamic mode, rather than pausing between runs. The ReaperThread calls the TransactionReaper.checkingPeriod() method to determine how long it should pause before it can invoke the TransactionReaper.check() method, however there exists a circumstance where the checkingPeriod() will return a negative period for a sustained time, resulting in the thread executing continuously. This occurs when the check() method is invoked while there are existing transactions in the ReaperElementManager. The check and checkingPeriod methods use the nextDynamicCheckTime variable to store the absolute time at which the next invocation of check should occur, checkingPeriod returns the difference between that time and the current. When the check method is executed after nextDynamicCheckTime has occurred, the method retrieves the first ReaperElement from the ReaperElementManager. The processing continues as follows - if no reaperElement present, reset nextDynamicCheckTime to Long.MAX_VALUE - if present and expired (reaperElement.getAbsoluteTimeout() <= now) then the element is processed - if present and not expired (reaperElement.getAbsoluteTimeout() > now) then do nothing. It is the last behaviour which is incorrect as the nextDynamicCheckTime still refers to the previous absolute timeout, i.e. < now, resulting in all calls to checkinPeriod() returning a negative value. This will only be halted if one of the other conditions is true, i.e. the ReaperElementManager is empty or the head element must be processed by this thread.
Suggested fix. --- ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/coordinator/TransactionReaper.java (revision 35354) +++ ArjunaCore/arjuna/classes/com/arjuna/ats/arjuna/coordinator/TransactionReaper.java (working copy) @@ -192,7 +192,9 @@ nextDynamicCheckTime.set(Long.MAX_VALUE); return; } else { - if(reaperElement.getAbsoluteTimeout() > now) { + final long nextTimeout = reaperElement.getAbsoluteTimeout() ; + if(nextTimeout > now) { + nextDynamicCheckTime.set(nextTimeout); return; // nothing to do yet. } }
Link: Added: This issue depends JBPAPP-5175
Link: Added: This issue is a dependency of SOA-2402
Resolved with revision 6955 of: build-tools/builders/eap/post-patch/patch_jbossts.xml (new) Committ message: SOA-2263 Overwrite jbossjts.jar with JBoss TS 4.6.1.CP08 from JBPAPP-5193. Change implVersion in jar-versions.xml.
JBPAPP-5193 contains builds of the fixed TS code (4.6.1.CP08).
Link: Added: This issue is related to JBPAPP-5193
Writer: Added: dlesage
Temporarily reopening to update release note info.
Release Notes Docs Status: Added: Documented as Resolved Issue Release Notes Text: Added: https://issues.jboss.org/browse/JBPAPP-5175 The JBossTS TransactionReaper contained a bug which caused it to execute continuously when it was running in dynamic mode, rather than pausing between runs. This caused performance degradation. To fix this issue, JBossTS was updated. As a result, the Reaper now pauses between runs, leading to better performance.
FYI - I had to re-open JBPAPP-5193. Please see my last comment there for details.