Bug 781707 - RHEV-H TUI: Network settings get lost when configuring nic
Summary: RHEV-H TUI: Network settings get lost when configuring nic
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: ovirt-node
Version: 6.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: 6.3
Assignee: Fabian Deutsch
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-14 14:46 UTC by Tomas Von Veschler
Modified: 2016-04-26 15:57 UTC (History)
10 users (show)

Fixed In Version: ovirt-node-2.3.0-4.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 830691 (view as bug list)
Environment:
Last Closed: 2012-07-19 14:17:41 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0741 0 normal SHIPPED_LIVE ovirt-node bug fix and enhancement update 2012-07-19 18:10:46 UTC

Description Tomas Von Veschler 2012-01-14 14:46:34 UTC
Description of problem:

When configuring RHEV-H, at the Network menu, if you fill all the fields (hostname, dns, ntp) and then press enter to configure a nic, after configuring the nic all the fields in the previous screen gets lost.

Version-Release number of selected component (if applicable):

rhevh-6.2-20111215.0.iso

How reproducible:

Always

Steps to Reproduce:
1. Install RHEV-H from ISO
2. On the interactive installer, enter the Network menu
3. Fill hostname, dns, ntp, then move to one nic, enter the nic configuration screen, finish configuration to be back to Network menu
  
Actual results:

The fields hostname, dns and ntp are blank again

Expected results:

hostname, dns and ntp values are kept

Additional info:

Comment 2 Guohua Ouyang 2012-01-16 02:43:16 UTC
The hostname, dns, ntp settings are kept when you just apply it on the same page.
After enter to configure nic page, it only saves the nic's configuration.

I think it is by design.

Comment 3 Tomas Von Veschler 2012-01-16 09:07:32 UTC
That's correct, this report was to improve UX. The current menu items are ordered in this way:

1. Hostname
2. DNS
3. NTP
4. Nics
5. Apply button

Users I've seen, follow that order of actions. As it is now, forces the user to go from 3. to 5., reenter the menu and go to 4. All this if the user already knows this flow, first time users will most likely miss it and will need to reenter the details twice.

Comment 4 Mike Burns 2012-01-16 13:23:23 UTC
Quick thoughts on this:

- Move Nics menu to first on the page
- add a warning if going into nics and there is unsaved data on the page
- Disable entry on other options if no nic is configured
- Maybe hide the other options on the screen with a message to "Configure a NIC to unlock other network options" (Not sure if technically feasible, but probably the best UX overall)

Comment 5 Fabian Deutsch 2012-03-29 15:36:42 UTC
(In reply to comment #4)
> Quick thoughts on this:
> 
> - Move Nics menu to first on the page
> - add a warning if going into nics and there is unsaved data on the page

This would be the most intuitive to me.

> - Disable entry on other options if no nic is configured

I think that this would confuse people if it's not directly visible that you have to configure a nic first.

> - Maybe hide the other options on the screen with a message to "Configure a NIC
> to unlock other network options" (Not sure if technically feasible, but
> probably the best UX overall)

Comment 6 Fabian Deutsch 2012-04-05 14:44:20 UTC
tui: Confirm NIC configuration conditionally

Display a confirmation dialog when jumping into the NIC configuration
and there are TUI changes in the network configuration.

http://gerrit.ovirt.org/#change,3352

Comment 7 Tomas Von Veschler 2012-04-09 07:07:37 UTC
If I understood it correctly the patch will show the following warning if unsaved changes are detected:

"The network changes will be lost when configuring a NIC, proceed?"

IMO still generates confusion:

1) user's default intention will probably be not loosing changes
2) no indication on how to avoid loosing the changes

What I'd suggest would be a more natural flow like:

"Unsaved network changes detected, save and continue to NIC configuration?"

Comment 8 Fabian Deutsch 2012-04-10 15:19:39 UTC
(In reply to comment #7)
> What I'd suggest would be a more natural flow like:
> 
> "Unsaved network changes detected, save and continue to NIC configuration?"

Thanks for this comment. I modified the message to reflect your suggestions. If the users selects "ok" the changes are also saved directly.

http://gerrit.ovirt.org/3429

Comment 9 Tomas Von Veschler 2012-04-10 16:43:17 UTC
Without having tested the patch, this solves in my opinion the original issue. Thanks :-)

Comment 11 Guohua Ouyang 2012-04-16 07:26:51 UTC
tested on 6.3-20120411.1, still have two problem need to fix:
1. before configure nic, write dns or hostname on network page.
2. select the nic and press enter.
3. it pop-up a window "Unsaved network changes detected, save and continue to NIC configuration?"
4. if choose ok, the info is saved and displayed on the ui.
5. if choose cancel, it returns to network page, but with the unsaved info even you move up/down between pages, it should reset the page.
6. it cannot saved dns info after configure nic with dhcp, it should save dns info by add "PEERDNS=no" to ifcfg-ethX, there is already bugs complaint it bz742365.

please fix 5&6 above.

Comment 16 Fabian Deutsch 2012-04-16 13:14:25 UTC
http://gerrit.ovirt.org/#change,3569

Reset network informations on page switch and keep them if "Cancel" is selected in the popup dialog.

Comment 17 Fabian Deutsch 2012-04-16 17:56:36 UTC
Tested with the patch above on upstream.

Testing procedure:
- Install
- Enter TUI and select the Network page
- Change hostname, by appending YYY
- Select a NIC entry and press RETURN
- The "Unsaved changes detected" warning appears, press "Cancel"
=> The Network page is displayed, with the modified entries (e.g. hostanem has still YYY appended).
- Select NIC and press RETURN
- The "Unsaved changes detected" warning appears, press "Apply"
- The NIC Details page appears, select "Back"
=> The Network page appears, the modification in the entries is persisted (e.g. the hostname has the suffix YYY)
- Change the hostname once again, by appending UUU
- Switch to the Status page
- Return to the Network page
=> The modifications are removed, thus the UUU suffix is removed.

Comment 20 Guohua Ouyang 2012-04-28 05:51:35 UTC
verified on rhevh-6.3-20120426.2 build, the unsaved info is kept when choose "cancel" on "confirm Nic Configuration" window. When move between network page and status page, the unsaved info is reset.

For the unsaved dns info will be tracked by bz742365.

Comment 21 Mike Burns 2012-06-13 16:44:37 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No tech note necessary

Comment 22 Stephen Gordon 2012-06-15 13:57:08 UTC
Deleted Technical Notes Contents.

Old Contents:
No tech note necessary

Comment 24 errata-xmlrpc 2012-07-19 14:17:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0741.html


Note You need to log in before you can comment on or make changes to this bug.