Bug 781738 - Configuration dialog is not internationalized
Summary: Configuration dialog is not internationalized
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: volumeicon
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-14 18:57 UTC by Raphael Groner
Modified: 2012-05-09 17:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-01-14 19:04:23 UTC
Type: ---

Attachments (Terms of Use)
patch to use gettext for i18n support (1.45 MB, text/plain)
2012-03-01 21:58 UTC, Raphael Groner 		no flags Details
patch to support i18n via gettext (3.46 KB, patch)
2012-03-01 22:24 UTC, Raphael Groner 		no flags Details | Diff
volumeicon.pot (1.96 KB, text/plain)
2012-03-01 22:25 UTC, Raphael Groner 		no flags Details
de.po (2.36 KB, text/plain)
2012-03-01 22:26 UTC, Raphael Groner 		no flags Details
patch for preferences.ui to work properly with xgettext (2.24 KB, patch)
2012-03-01 22:29 UTC, Raphael Groner 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Raphael Groner 2012-01-14 18:57:00 UTC 
Description of problem:
Configuration dialog is only available in english.

Version-Release number of selected component (if applicable):
rawhide

How reproducible:
yes

Steps to Reproduce:
1. right click on systray icon and select preferences
2.
3.
  
Actual results:
Preferences dialog in english.

Expected results:
I18n support for preferences.

Additional info:
I could do the german part of translation, and maybe also patch the source if needed.
Comment 1 Christoph Wickert 2012-01-14 19:04:23 UTC 
This is a feature request and has nothing to do with packaging or Fedora. Please bring this up upstream.
Comment 2 Raphael Groner 2012-03-01 21:58:42 UTC 
Created attachment 566954 [details]
patch to use gettext for i18n support

Please review this patch, so I can file it upstream to the developer.

What I have done in short: I used the following howtos.

http://www.gnu.org/software/gettext/manual/gettext.html
http://www.servin.com/linux/GladeInternationalization.html

to enable xgettext support for UI:
- rename preferences.ui in preferences.glade
- mark "column" and "column2" in preferences.glade as translatable="no"

$ xgettext -o po/volumeicon.pot -s -k_ src/volumeicon.c data/gui/preferences.glade
Comment 3 Raphael Groner 2012-03-01 22:24:34 UTC 
Created attachment 566956 [details]
patch to support i18n via gettext

Sorry, the first patch was crapped with binary stuff.
Comment 4 Raphael Groner 2012-03-01 22:25:36 UTC 
Created attachment 566957 [details]
volumeicon.pot
Comment 5 Raphael Groner 2012-03-01 22:26:37 UTC 
Created attachment 566958 [details]
de.po
Comment 6 Raphael Groner 2012-03-01 22:29:48 UTC 
Created attachment 566959 [details]
patch for preferences.ui to work properly with xgettext

rename data/gui/preferences.ui to data/gui/preferences.glade
Comment 7 Raphael Groner 2012-05-09 16:48:31 UTC 
Upstream seems to be aware of a need for i18n support.

https://github.com/Maato/volumeicon/pull/3
https://github.com/Maato/volumeicon/pull/8
Comment 8 Raphael Groner 2012-05-09 17:11:20 UTC 
(In reply to comment #7)
> Upstream seems to be aware of a need for i18n support.
Correct links:
https://github.com/Maato/volumeicon/issues/3
https://github.com/Maato/volumeicon/pull/8
Note You need to log in before you can comment on or make changes to this bug.