Hide Forgot
* Import a VM from import domain. * Try importing the same VM again, which should fail on CanDoAction. * First a (false) success pop-up is shown (with the text "Import process has begun for VM(s)..."). * After clicking on close, a CanDoAction failure pop-up is shown (with the text "Error... Import VM failed..."). The failure pop-up should be shown instead of the success pop-up. Showing both is illogical.
The error pop-up is not necessarily an error that has been thrown during the CanDoAction phase; it might have been thrown during the execution phase, which is being executed in an async manner (therefore, blocking the success pop-up in this case is extremely problematic). Can you please provide the exact text that was included in the error pop-up? a screen shot and engine-core logs in addition would also be appreciated.
The only relevant log for this action is: 2012-01-15 17:08:14,874 WARN [org.ovirt.engine.core.bll.ImportVmCommand] (http--0.0.0.0-8080-10) CanDoAction of action ImportVm failed. Reasons:VM_CANNOT_IMPORT_VM_EXISTS,$VmName paikov-vdc-22,VAR__ACTION__IMPORT,VAR__TYPE__VM The text of the first error: Import process has begun for VM(s): . You can check import status in the 'Events' tab of the specific destination storage domain, or in the main 'Events' tab The text of the second error: Error: <vm>: Import VM failed - VM Id already exist in the system. Please remove the VM (paikov-vdc-22) from the system first
according to the info in Comment #2, it seems like the action hasn't succeeded for any of the VMs (since the list of VMs is empty). In this case, the "Import Process has begun for VM(s)..." shouldn't appear at all.
The list of VMs isn't empty. I just replaced the name of the VM with <vm>.
(In reply to comment #4) > The list of VMs isn't empty. I just replaced the name of the VM with <vm>. I am talking about the first message: "Import process has begun for VM(s): . You can check import status in the 'Events' tab of the specific destination storage domain, or in the main 'Events' tab" After the "... has begun for VM(s):" part, there was suppose to be a list of VM names for which the import process has started. It seems to be empty. Is it empty? Or did you remove the list-of-VM-names part from the message when documenting it in Comment #2?
Whoops. Yes, this list is indeed empty.
pushed patch for review: http://gerrit.ovirt.org/#change,1064
merged to git: 578c3116750c4bb67351d4f0642744def4d8ef04
I'm not sure if the list being empty is an indication of anything. The list is also empty when the import action is successful. I'll open a separate bug on this issue.
Well, calculating the list of VMs that can be imported was broken (always calculated, that no VMs can be). To fix the issue that the false success popup shows up it was also needed to fix this algorithm. So please don't open a new bug, it was part of this bug and has already been fixed, pushed and merged.
Checked on upstream.