Hide Forgot
Created attachment 555361 [details] Patch to fix ignoring input from ffdc iMon device Description of problem: I have an iMON device (device ID 15c2:ffdc) in my multimedia pc, which worked without too many problems with pre-3.x kernels and the lirc_imon module. With the new imon module since kernel 3.0 the remote worked as expected, just everytime the module got reloaded or the machine was rebooted, the machine got a kernel oops. With kernel version 3.2, the oops is fixed, but now the input from the remote is not recognized at all. There are no input entries in the log. I have a patch to drivers/media/rc/imon.c for this issue which works for me(TM), but I'm not sure it's the right thing to do. With this patch keypresses from the remote are recognized and the kernel oops doesn't occur either. The patch is attached. Version-Release number of selected component (if applicable): kernel-3.2.1-4.fc17.src.rpm Corinna
Ping? Is anything essential missing in this bug report/patch submission? TIA, Corinna
(In reply to comment #1) > Ping? Is anything essential missing in this bug report/patch submission? Sorry, this report got lost in the sea of bugs. The one simple thing I can comment on is that the patch would need to be at strip level one to be readily applicable. Jarod, Mauro, can you review the patch and see if it's suitable for upstream submission?
(In reply to comment #2) > (In reply to comment #1) > > Ping? Is anything essential missing in this bug report/patch submission? > > Sorry, this report got lost in the sea of bugs. The one simple thing I can > comment on is that the patch would need to be at strip level one to be readily > applicable. > > Jarod, Mauro, can you review the patch and see if it's suitable for upstream > submission? The patch looks ok on my eyes. We need patch author's Signed-off-by, in order to merge it upstream. A Jarod's ack would also be a nice-to-have. The better procedure would be if Corinna could send the patch with the SOB on it, to the linux-media.org. I'll get it there and apply upstream.
Hi, I'll send the original report with a fixed patch and a SOB to the linux-media list in a couple of minutes. Thanks guys, Corinna
Will hopefully take a closer look tomorrow. I think it might actually be that we need some additional locking to ensure that intf0 init has actually finished before we start processing packets.
I just sent an updated patch based on Corinna's but with a bit more detail on what's going on and the same treatment for the second imon device interface to linux-media, and I've verified it with both an ffdc device and a newer device. Wasn't the locking like I was thinking, it was the callback firing, and us bailing without submitting a new rx urb.
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/43872/focus=43980 which still isn't in linux-next or any other tree I can find.
Mauro has it queued up here at least: http://git.linuxtv.org/mchehab/media-next.git I've asked that it get sent along for v3.3. with 3.2-stable cc'd.
(In reply to comment #8) > Mauro has it queued up here at least: > > http://git.linuxtv.org/mchehab/media-next.git > > I've asked that it get sent along for v3.3. with 3.2-stable cc'd. I see. I was looking at the two trees below. Those seem stale: http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-media.git;a=summary http://git.kernel.org/?p=linux/kernel/git/mchehab/media-next.git;a=summary
OK, threw the patch in f17 and rawhide since it's queued in a tree somewhere now.
kernel-3.3.0-0.rc4.git1.4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kernel-3.3.0-0.rc4.git1.4.fc17
Package kernel-3.3.0-0.rc4.git1.4.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.3.0-0.rc4.git1.4.fc17' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-2304/kernel-3.3.0-0.rc4.git1.4.fc17 then log in and leave karma (feedback).
kernel-3.3.0-0.rc4.git1.4.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
Got this note this morning: This is a note to let you know that I've just added the patch titled [media] imon: don't wedge hardware after early callbacks to the 3.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: imon-don-t-wedge-hardware-after-early-callbacks.patch and it can be found in the queue-3.2 subdirectory. So this should also get taken care of automagically for Fedora 16 by way of a 3.2-stable update at some point in the future.