Spec URL: http://kwizart.fedorapeople.org/review/aimage.spec SRPM URL: http://kwizart.fedorapeople.org/review/aimage-3.2.5-1.fc17.src.rpm Description: Advanced Disk Imager Upstream has resurrected this package to make it compliant with newer afflib.
You can remove defattr. It seems to me, there is no afflib in EL. If I'm right and you don't want to introduce it there, you can drop everything specific for EPEL 5 packaging: - Buildroot definition - rm in install section - clean section More important things: - Add COPYING to %doc - Resolve the format warnings in the build - "WARNING: unrecognized options: --enable-opt" - Does aimage make use of ncurses and readline? It seeks for them and also tries to link.
Spec URL: http://kwizart.fedorapeople.org/review/aimage.spec SRPM URL: http://kwizart.fedorapeople.org/review/aimage-3.2.5-2.fc17.src.rpm Description: Advanced Disk Imager Changelog: - Bump afflib requirement - Add COPYING - Remove uneeded section - Note on why readline is incompatible license wise - Add BR ncurses-devel Note that this package target f17. Thx for the reviews.
What is your intention with requireing a specific version of afflib-devel? I note you're targeting F17, but if the afflib version changes there, you have to update your spec file. If there is a good reason, please comment on the spec file. I'd personally like to see a better description text. Resolving the format warnings in the build should be fairly easy and not bare any risk. Please do it, if possible and submit it to the author/s. Besides that everything looks fine, I'll take the review.
Can you gather any kind of documentation?
Hi, I think the spec file is obvious. aimage requires at least a specific version of afflib, period. That's exactly what BuildRequires afflib >= 3.6.15 means. aimage/afflib are both from afflib.org, so when one is updated another comes along. A previous aimage used to be in earlier fedora. I have orphaned it because it was orphaned upstream over another tool. But as it has been resurrected, that's need a new review. Which format-warning are you talking about ? There is no documentation The description was picked from the website: http://afflib.org/software/aimage-the-advanced-disk-imager Thx for the review
aimage remains in in-between state, but since the FTBFS is fixed that good for me to let it go without a maintainer.