Bug 784075 - [PATCH] tar extraction fails when the Drag'n'Drop target path contains spaces
Summary: [PATCH] tar extraction fails when the Drag'n'Drop target path contains spaces
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xarchiver
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaromír Cápík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-23 18:34 UTC by Jaromír Cápík
Modified: 2016-02-01 01:56 UTC (History)
2 users (show)

Fixed In Version: xarchiver-0.5.2-13.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-01 09:31:55 UTC
Type: ---


Attachments (Terms of Use)
xarchiver-0.5.2-whitespaces_in_path.patch (1.65 KB, patch)
2012-01-23 18:36 UTC, Jaromír Cápík
no flags Details | Diff
xarchiver-0.5.2-drag-n-drop_escaped_path.patch (780 bytes, patch)
2012-01-23 19:15 UTC, Jaromír Cápík
no flags Details | Diff
xarchiver-0.5.2-drag-n-drop_escaped_path.patch (885 bytes, patch)
2012-01-23 19:48 UTC, Jaromír Cápík
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 914864 0 unspecified CLOSED Thunar does not compress files nor directories with space in the name 2021-02-22 00:41:40 UTC

Internal Links: 914864

Description Jaromír Cápík 2012-01-23 18:34:49 UTC
Description of problem:
When I try to drag files from tar archives opened with Xarchiver and drop them to a directory containing spaces in the path, the extraction fails, since the tar command is missing quotation marks.
The attached patch solves the issue.

Version-Release number of selected component (if applicable):
0.5.2-11

Comment 1 Jaromír Cápík 2012-01-23 18:36:01 UTC
Created attachment 557022 [details]
xarchiver-0.5.2-whitespaces_in_path.patch

Comment 2 Jaromír Cápík 2012-01-23 19:15:59 UTC
Created attachment 557036 [details]
xarchiver-0.5.2-drag-n-drop_escaped_path.patch

The following patch fixes the issue better ... works for all characters which need to be escaped ...

Comment 3 Jaromír Cápík 2012-01-23 19:48:34 UTC
Created attachment 557050 [details]
xarchiver-0.5.2-drag-n-drop_escaped_path.patch

The previous one could produce unwanted memory leaks by leaving the original unescaped path unfreed.

Comment 4 Christoph Wickert 2012-01-24 15:06:27 UTC
Thanks for the patch. I have just given you commit access, so you can check this in yourself. Please make sure to add useful comments in the spec and issue updates as necessary and let the close this bug.

Comment 5 Jaromír Cápík 2012-01-26 11:39:10 UTC
Ok .... thank You. Gonna do that.

Comment 6 Fedora Update System 2012-01-26 13:11:13 UTC
xarchiver-0.5.2-13.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/xarchiver-0.5.2-13.fc16

Comment 7 Fedora Update System 2012-01-26 13:13:35 UTC
xarchiver-0.5.2-13.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xarchiver-0.5.2-13.fc15

Comment 8 Fedora Update System 2012-01-26 22:54:31 UTC
Package xarchiver-0.5.2-13.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xarchiver-0.5.2-13.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-0948/xarchiver-0.5.2-13.fc16
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2012-03-01 09:31:55 UTC
xarchiver-0.5.2-13.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2012-03-01 09:35:08 UTC
xarchiver-0.5.2-13.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.