Hide Forgot
Description of problem: I create a repo with wrong feed. The repo failed to sync. Now I deleted repo and create another repo with the same name with a valid feed and synced. Now if I tried to delete the repo repo delete fails. I had to repeat it a couple of times. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. create a repo test with a wrong feed and sync 2. Delete the repo 3. Create a repo with the same name (test) with a valid feed. 4. Sync the repo 5. delete the repo (see in pulp.log) 6. Repeat step 1-5 again and see in pulp.log Actual results: Repo being deleted message Expected results: 2012-01-24 11:18:21,206 11740:140452267288320: pulp.server.tasking.task:ERROR: task:455 Task failed: Task 08607e33-46a7-11e1-8980-002564a85a58: RepoApi.delete(test2, ) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/pulp/server/tasking/task.py", line 404, in run result = self.callable(*self.args, **self.kwargs) File "/usr/lib/python2.7/site-packages/pulp/server/api/repo.py", line 560, in delete self._delete_published_link(repo) File "/usr/lib/python2.7/site-packages/pulp/server/api/repo.py", line 383, in _delete_published_link os.unlink(link_path) OSError: [Errno 21] Is a directory: '/var/lib/pulp/published/repos/repos/pulp/pulp/6Server' Additional info:
commit 6080f631541208858c9040d9fc4081cbfd9c04c3 Make sure you clean up /var/lib/pub/published dir with any empty dir before running your test. the issue is not any two repos, its overlapping feed relativepaths and the way delete cleans up published dirs. When we delete today we remove the symlink, but dont remove empty dirs from published dirs. So /var/lib/pulp/published/repos/repos/pulp/pulp/testing/fedora-16/ if left as it is. The fix is to make sure unpublish during delete removes those dirs after unlinking.
build: 0.263
build: 0.264
verified [root@preethi ~]# rpm -q pulp pulp-0.0.264-1.fc15.noarch [root@preethi ~]# pulp-admin repo delete --id test1 Repository [ test1 ] being deleted [root@preethi ~]# pulp-admin repo create --id test1 --feed=http://repos.fedorapeople.org/repos/pulp/pulp/testing/6Server/x86_64/ Successfully created repository [ test1 ] [root@preethi ~]# pulp-admin repo sync --id test1 -FSync for repository test1 started Sync: Finished 20/20 new items downloaded 0/20 existing items processed Item Details: RPMs: 20/20 [root@preethi ~]# pulp-admin repo delete --id test1 Repository [ test1 ] being deleted [root@preethi ~]# rpm -q pulp pulp-0.0.264-1.fc15.noarch
Pulp v1.0 is released Closed Current Release.