Bug 784379 - webadmin - the layout is broken after reinstall engine
Summary: webadmin - the layout is broken after reinstall engine
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-webadmin
Version: unspecified
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
: 3.1
Assignee: Einav Cohen
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-24 17:58 UTC by Pavel Stehlik
Modified: 2016-01-28 21:54 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-08-09 07:57:18 UTC
oVirt Team: ---


Attachments (Terms of Use)
host-pm (19.30 KB, image/png)
2012-01-24 17:58 UTC, Pavel Stehlik
no flags Details

Description Pavel Stehlik 2012-01-24 17:58:51 UTC
Created attachment 557279 [details]
host-pm

Description of problem:
 Using engine-clean, then yum upgrade to new version (..1.3). Then couple oof things happened:
1) the login dialog doesn't show any data in it (at least internal domain should be there)
 - could be solved by using 'Clear recent history' (but what about other data from different pages?? - those can't be excluded from this action)

2) see att pic - Host / PM setting
 - the layout is broken - the Address label is moved & other fields don't correspond with labels any more (clearly visible on password/options fields).

Already showed to vszocs.


Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-3.0.0_0001-1.3.fc16.x86_64

How reproducible:
1) 100%
2) not sure that I'll be able to reproduce again

Steps to Reproduce:
1. have an older release (3.0.0_0001-1.2.fc16.x86_64) then engine-clean & yum update
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Moran Goldboim 2012-01-29 21:55:46 UTC
Pavel any chance this is a browser issue - similar to https://bugzilla.redhat.com/show_bug.cgi?id=785523 ?

Comment 2 Pavel Stehlik 2012-01-30 08:36:58 UTC
(In reply to comment #1)
> Pavel any chance this is a browser issue - similar to
> https://bugzilla.redhat.com/show_bug.cgi?id=785523 ?

I put command also there:
I've 9.0.1 on F16 - jlibosva has 9.0.1 as well & on his setup looks ok. So I
still think it's some caching issue.

I'd mark Paikov's BZ as dup of this one (sorry David, but your BZ is younger) :)

P.

Comment 3 Vojtech Szocs 2012-01-31 13:47:03 UTC
Hi, for issue #1 (login dialog doesn't show any data), quick fix for FireFox:

Tools | Clear recent history > Time range to clear = Everything, in Details put checkmark only to Cache and Site preferences (other things don't need to be cleared). After this, close WebAdmin browser tab and request WebAdmin again in new browser tab.

I've tried to reproduce issue #1: build WebAdmin, then add some test changes (simulate new version), build WebAdmin again and compare output artifacts.

The only collision I've found is within the file "webadmin.nocache.js", this is the GWT selector script that loads correct application permutation for the given environment (e.g. browser type and version). Upon each WebAdmin recompile, strong names for GWT application permutations change, and therefore contents of "webadmin.nocache.js" file changes.

To me, the problem seems to be that "webadmin.nocache.js" is cached on the client (browser). I have done following steps:

0) deploy original WebAdmin, start JBoss

1) request "webadmin.nocache.js", HTTP response header contains Etag W/"6077-1327940883000"

2) request "webadmin.nocache.js" again, request hits the server but server says the resource didn't change, browser uses cached version of "webadmin.nocache.js"

3) stop JBoss, deploy changed WebAdmin, start JBoss (I am not touching browser cache settings)

4) request "webadmin.nocache.js", request hits the server but server again says the resource didn't change, browser uses cached version of "webadmin.nocache.js"

My question is, why JBoss returns the same Etag value when the underlying "webadmin.nocache.js" contents has changed?

But besides that, solution to this issue is following: in JBoss, disable cache control for files whose name contains "nocache" string

Comment 4 Vojtech Szocs 2012-01-31 13:54:00 UTC
Forgot to mention, the login (actually entire WebAdmin) is broken because browser uses old version of "webadmin.nocache.js" that references non-existing permutations. Disabling caching for *nocache* files should fix this issue.

However, I wasn't able to reproduce issue #2 (broken Host dialog layout).

Comment 5 Vojtech Szocs 2012-01-31 14:30:27 UTC
Perhaps the best solution, as proposed by lhornyak, would be to write custom Servlet Filter that handles *nocache* static file requests. This filter could be part of "frontend" project (contains server-side classes for both WebAdmin and UserPortal).

Comment 6 Vojtech Szocs 2012-02-02 15:42:40 UTC
Proposed fix submitted to Gerrit: http://gerrit.ovirt.org/1593

Comment 7 Vojtech Szocs 2012-02-10 13:04:36 UTC
New fix submitted to Gerrit: http://gerrit.ovirt.org/1802

This patch replaces the previous one. Please see the commit message for details on this fix.

Comment 8 Vojtech Szocs 2012-02-13 13:51:53 UTC
Fix for issue #1 (login dialog doesn't show any data after oVirt upgrade) has been merged upstream.

Comment 9 Vojtech Szocs 2012-03-20 10:47:54 UTC
As for issue #2 (Host PM dialog layout broken): couldn't reproduce in Firefox 10 and IE 8.

According to description, the most probable cause for this might be CSS styling. If the user overrides his own browser's CSS rules (e.g. increases default font size), this might interfere with the application styling.

Pavel, can you please verify if this problem persists? Which browser/version are you using?

Comment 10 Vojtech Szocs 2012-03-21 14:12:48 UTC
Issue #2: as discussed with Pavel, the problem persists even after he upgraded his Firefox from version 9 to version 11 (latest). Strangely, this problem doesn't occur for other people.

Anyway, we've been able to narrow down the cause for this. I'll test it on FF 10 and IE 8, making sure there are no visual regressions.

Comment 11 Vojtech Szocs 2012-03-21 14:54:23 UTC
Fix for issue #2 submitted to Gerrit: http://gerrit.ovirt.org/2994

Comment 12 Pavel Stehlik 2012-03-22 10:55:39 UTC
I am using:
default font size = 16
default font = Serif
minimum font size = None

Looks like normal setting.

Comment 13 Vojtech Szocs 2012-03-26 09:25:55 UTC
Patches for both issues have been pushed (merged) upstream.

Pavel, can you please verify that it works for you?

Comment 14 Itamar Heim 2012-08-09 07:57:18 UTC
closing ON_QA bugs as oVirt 3.1 was released:
http://www.ovirt.org/get-ovirt/


Note You need to log in before you can comment on or make changes to this bug.