Bug 784386 - cleanup: unused config values for notification service in engine core
Summary: cleanup: unused config values for notification service in engine core
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Greg Padgett
QA Contact:
URL:
Whiteboard: infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-01-24 18:14 UTC by Itamar Heim
Modified: 2016-06-12 23:15 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-23 09:21:21 UTC
oVirt Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Itamar Heim 2012-01-24 18:14:17 UTC 
the notification service configuration is now done via a .conf file, rather than as part of engine config.

seems like the following can be removed from ConfigValues class (and if they exist in the db for some reason)

    ENMailHost(183),
    ENMailPort(184),
    ENMailUser(185),
    ENMailPassword(186),
    ENMailDomain(187),
    ENMailIsBodyHtml(188),
    ENMailEnableSsl(189),
    ENMailUseDefaultCredentials(190),
Comment 1 Doron Fediuck 2012-06-04 16:09:37 UTC 
Just a general comment, next time when moving to POST,
please add a comment with the proposed patch. This will make it easier
for reviewers to track the relevant patch(-set).
Comment 2 Greg Padgett 2012-06-04 16:13:57 UTC 
Thanks Doron, still getting the hang of the workflow and appreciate the feedback.  Is a link to the gerrit change appropriate? e.g. for this one:

http://gerrit.ovirt.org/#/c/4876
Comment 3 Doron Fediuck 2012-06-04 16:32:57 UTC 
That's perfect.
Once merged, please add a comment with a link to the merged fix in gitweb.
Comment 4 Itamar Heim 2012-12-23 09:21:21 UTC 
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.
Note You need to log in before you can comment on or make changes to this bug.