Hide Forgot
Spec URL: http://people.redhat.com/vondruch/rubygem-journey.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-journey-1.0.1-1.fc17.src.rpm Description: Journey is a router. It routes requests. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745455
I'll take this for a review.
- README.md should be present in the main package, as it contains licensing information. - Otherwise the package is OK (although, as FPC [1], I have a general feel of distaste about the bundled javascript libraries - but since they are currently allowed, it is not a blocker). [1] https://fedorahosted.org/fpc/ticket/113 So after you fix the issue, this package is APPROVED.
(In reply to comment #2) > - README.md should be present in the main package, as it contains licensing > information. Done > - Otherwise the package is OK (although, as FPC [1], I have a general feel of > distaste about the bundled javascript libraries - but since they are currently > allowed, it is not a blocker). > > [1] https://fedorahosted.org/fpc/ticket/113 > > > So after you fix the issue, this package is APPROVED. Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-journey Short Description: Journey is a router Owners: vondruch Branches: InitialCC:
Git done (by process-git-requests).