Hide Forgot
Version: ovirt-engine-iso-uploader-3.0.0_0001-1.4.fc16.x86_64 1. The usage printed to the screen says that upload option does not require file as mandatory parameter. It means that the line: engine-iso-uploader [options] upload [file].[file]...[file] should be replaced by: engine-iso-uploader [options] upload FILE [FILE]...[FILE] 2. This one is an RFE - I think it will be better to notify the user that the upload process has started, because it's not understood that the authentication against REST-API has finished and is not stuck, except for the return code. The log file is also empty in the below case. The current output: [root@rami-fed16-6 ~]# engine-iso-uploader -i rvaknin_iso_domain upload Fedora-16-x86_64-Live-Desktop.iso Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to abort): [root@rami-fed16-6 ~]#
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.
Papercut, and I think it should be done. I wasn't thrilled about the help screen - it's difficult to find right away what needs to be the command line. I'd also make sure that when entering 'rhevm-iso-uploader' without any parameters it'll display the help screen, and not just suggest to run with '-h'.
(In reply to comment #0) > 2. This one is an RFE - I think it will be better to notify the user that > the upload process has started, because it's not understood that the > authentication against REST-API has finished and is not stuck, except for > the return code. The log file is also empty in the below case. > > The current output: > > [root@rami-fed16-6 ~]# engine-iso-uploader -i rvaknin_iso_domain upload > Fedora-16-x86_64-Live-Desktop.iso > Please provide the REST API password for the admin@internal oVirt Engine > user (CTRL+D to abort): > [root@rami-fed16-6 ~]# Maybe also an upload progress status (just a % or a progress bar or a ETA) could be useful here.
(In reply to comment #0) > 1. The usage printed to the screen says that upload option does not require > file as mandatory parameter. > > It means that the line: > engine-iso-uploader [options] upload [file].[file]...[file] > > should be replaced by: > engine-iso-uploader [options] upload FILE [FILE]...[FILE] this one submitted for review with patch 12288.
(In reply to comment #0) > 2. This one is an RFE - I think it will be better to notify the user that > the upload process has started, because it's not understood that the > authentication against REST-API has finished and is not stuck, except for > the return code. The log file is also empty in the below case. This one submitted for review fith patch 12295 (In reply to comment #3) > Maybe also an upload progress status (just a % or a progress bar or a ETA) > could be useful here. Added a notification of starting upload for every FILE in argument list. On a fast network it seems enough.
patch 12288 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-iso-uploader.git;a=commit;h=ad005cc74f46cf1350aacf6796137a74c5ca255c
patch 12295 merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-iso-uploader.git;a=commit;h=6d252e108d55d877ce227d0dcbb40c931380b191