Hide Forgot
Spec URL: http://bkabrda.fedorapeople.org/pkgs/map/rubygem-map.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/map/rubygem-map-5.2.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3745841 Description: The awesome ruby container you've always wanted: a string/symbol indifferent ordered hash that works in all rubies.
I take it for a review.
* Spec file differences - The spec file you provides differs from the spec file in SRPM. The SRPM version looks better IMO. Please make sure which one you are using. * License - The license file says "same as ruby's". However, the license between Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with upstream? Otherwise I have no other concerns => APPROVED.
(In reply to comment #2) > * Spec file differences > - The spec file you provides differs from the spec file in SRPM. The SRPM > version looks better IMO. Please make sure which one you are using. Sorry about that, fixed :) > * License > - The license file says "same as ruby's". However, the license between > Ruby 1.8 and Ruby 1.9, differs. Would you mind to clarify the license with > upstream? > Solved to BSD or Ruby: https://github.com/ahoward/map/issues/10 > Otherwise I have no other concerns => APPROVED. New Package SCM Request ======================= Package Name: rubygem-map Short Description: String/symbol indifferent ordered hash Owners: bkabrda Branches: InitialCC:
Git done (by process-git-requests).