Bug 786682 - `make bkradd` returns 0 when package was not added because of incorrect TestTime value
Summary: `make bkradd` returns 0 when package was not added because of incorrect TestT...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: scheduler
Version: 0.6
Hardware: Unspecified
OS: Unspecified
unspecified
low vote
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 545868
TreeView+ depends on / blocked
 
Reported: 2012-02-02 06:55 UTC by Jan Hutař
Modified: 2019-05-22 13:42 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-20 00:39:03 UTC


Attachments (Terms of Use)

Description Jan Hutař 2012-02-02 06:55:53 UTC
Description of problem:
Beaker denies to import task rpm with TestTime in days ("d") but `make bkradd` returns 0.


Version-Release number of selected component (if applicable):
Version - 0.8.0
rhts-devel-4.43-1.git.6.4ea8ce6.el6eso.noarch


How reproducible:
1 of 1 attempt


Steps to Reproduce:
1. # grep TestTime Makefile
@echo "TestTime:     2d" >> $(METADATA)
2. # make bkradd
[...]
+ exit 0
/mnt/testarea/rhts-build-yq0wUanm/install ~/Checkouts/GIT/RHN-Satellite/Installer/Sanity/install2
RHN-Satellite-CoreOS-RHN-Satellite-Installer-Sanity-install2-2.0-2.noarch.rpm
Exception: <Fault 1: "<class 'bkr.server.testinfo.ParserWarning'>:TestTime unit is not valid, should be m (minutes) or h (hours)">
~/Checkouts/GIT/RHN-Satellite/Installer/Sanity/install2
Finished building test package
rm testinfo.desc
3. # echo $?
0


Actual results:
Test fails to import and `make bkradd` reports 0


Expected results:
`make bkradd` should report != 0

Maybe even rhts-lint which reports this as well might stop build&push process?

Comment 1 Branislav Náter 2012-06-19 09:03:26 UTC
Same when importing version that already exists. It's because last command "rm testinofo.desc" finished successfully.

python-ethtool-CoreOS-python-ethtool-Sanity-memory-1.0-1.noarch.rpm
Exception: <Fault 1: "<class 'bkr.common.bexceptions.BX'>:u'Failed to import,  1.0-1 is the same version we already have'">
~/tests/python-ethtool/Sanity/memory
Finished building test package
rm testinfo.desc
# echo $?
0

It's anoying because we're unable to pipe commands according success/fail. Please fix this. Thanks.

Comment 2 Dan Callaghan 2012-07-05 07:32:48 UTC
On Gerrit: http://gerrit.beaker-project.org/1179

Comment 5 Dan Callaghan 2012-07-20 00:39:03 UTC
Beaker 0.9.1 has been released.


Note You need to log in before you can comment on or make changes to this bug.