Bug 787199 - Review Request: perl-Tree-XPathEngine - Re-usable XPath engine
Summary: Review Request: perl-Tree-XPathEngine - Re-usable XPath engine
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-03 14:09 UTC by Petr Šabata
Modified: 2012-02-03 15:12 UTC (History)
3 users (show)

Fixed In Version: perl-Tree-XPathEngine-0.05-1.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-03 15:12:50 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2012-02-03 14:09:23 UTC
Spec URL: http://psabata.fedorapeople.org/pkgs/Tree-XPathEngine/perl-Tree-XPathEngine.spec
SRPM URL: http://psabata.fedorapeople.org/pkgs/Tree-XPathEngine/perl-Tree-XPathEngine-0.05-1.fc16.src.rpm
Description:
This module provides an XPath engine, that can be re-used by other
module/classes that implement trees.

Comment 1 Petr Pisar 2012-02-03 14:39:03 UTC
Source file is original. Ok.
Summary verified from lib/Tree/XPathEngine.pm. Ok.

Description verified from lib/Tree/XPathEngine.pm. Ok.
TODO: Use plural of `module' in `module/classes'.

License verified from lib/Tree/XPathEngine.pm. Ok.
URL and Source0 are alive. Ok.
No XS code, narch BuildArch is Ok.

Build-requires are Ok.

All tests pass. Ok.

$ rpmlint perl-Tree-XPathEngine.spec ../SRPMS/perl-Tree-XPathEngine-0.05-1.fc17.src.rpm ../RPMS/noarch/perl-Tree-XPathEngine-0.05-1.fc17.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is OK.

$ rpm -q -lv -p ../RPMS/noarch/perl-Tree-XPathEngine-0.05-1.fc17.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Feb  3 15:28 /usr/share/doc/perl-Tree-XPathEngine-0.05
-rw-r--r--    1 root    root                      281 Feb 15  2006 /usr/share/doc/perl-Tree-XPathEngine-0.05/Changes
-rw-r--r--    1 root    root                      363 Feb 12  2006 /usr/share/doc/perl-Tree-XPathEngine-0.05/README
-rw-r--r--    1 root    root                     7849 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine.3pm.gz
-rw-r--r--    1 root    root                     1941 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Boolean.3pm.gz
-rw-r--r--    1 root    root                     1893 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Expr.3pm.gz
-rw-r--r--    1 root    root                     2021 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Function.3pm.gz
-rw-r--r--    1 root    root                     2330 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Literal.3pm.gz
-rw-r--r--    1 root    root                     1845 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::LocationPath.3pm.gz
-rw-r--r--    1 root    root                     2591 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::NodeSet.3pm.gz
-rw-r--r--    1 root    root                     2153 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Number.3pm.gz
-rw-r--r--    1 root    root                     1889 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Root.3pm.gz
-rw-r--r--    1 root    root                     2247 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Step.3pm.gz
-rw-r--r--    1 root    root                     1946 Feb  3 15:27 /usr/share/man/man3/Tree::XPathEngine::Variable.3pm.gz
drwxr-xr-x    2 root    root                        0 Feb  3 15:27 /usr/share/perl5/vendor_perl/Tree
drwxr-xr-x    2 root    root                        0 Feb  3 15:27 /usr/share/perl5/vendor_perl/Tree/XPathEngine
-rw-r--r--    1 root    root                    41306 Feb 15  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine.pm
-rw-r--r--    1 root    root                     1438 Feb 12  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Boolean.pm
-rw-r--r--    1 root    root                    19723 Feb 13  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Expr.pm
-rw-r--r--    1 root    root                    11045 Feb 15  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Function.pm
-rw-r--r--    1 root    root                     2276 Feb 12  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Literal.pm
-rw-r--r--    1 root    root                     1372 Feb 13  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/LocationPath.pm
-rw-r--r--    1 root    root                     4170 Feb 12  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/NodeSet.pm
-rw-r--r--    1 root    root                     2121 Feb 12  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Number.pm
-rw-r--r--    1 root    root                     1011 Feb 12  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Root.pm
-rw-r--r--    1 root    root                    10355 Feb 15  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Step.pm
-rw-r--r--    1 root    root                     1455 Feb 12  2006 /usr/share/perl5/vendor_perl/Tree/XPathEngine/Variable.pm
File permissions and layout is Ok.\

$ rpm -q --requires -p ../RPMS/noarch/perl-Tree-XPathEngine-0.05-1.fc17.noarch.rpm |sort |uniq -c
      1 perl(:MODULE_COMPAT_5.14.2)  
      1 perl(overload)  
      1 perl(strict)  
      1 perl(Tree::XPathEngine)  
      1 perl(Tree::XPathEngine::Boolean)  
      1 perl(Tree::XPathEngine::Expr)  
      1 perl(Tree::XPathEngine::Function)  
      1 perl(Tree::XPathEngine::Literal)  
      1 perl(Tree::XPathEngine::LocationPath)  
      1 perl(Tree::XPathEngine::NodeSet)  
      1 perl(Tree::XPathEngine::Number)  
      1 perl(Tree::XPathEngine::Root)  
      1 perl(Tree::XPathEngine::Step)  
      1 perl(Tree::XPathEngine::Variable)  
      1 perl(vars)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Require perl(POSIX) (lib/Tree/XPathEngine/Function.pm:339). Please note the module is not needed at test-time.

$ rpm -q --provides -p ../RPMS/noarch/perl-Tree-XPathEngine-0.05-1.fc17.noarch.rpm |sort |uniq -c 
      1 perl(Tree::XPathEngine) = 0.05
      1 perl-Tree-XPathEngine = 0.05-1.fc17
      1 perl(Tree::XPathEngine::Boolean)  
      1 perl(Tree::XPathEngine::Expr)  
      1 perl(Tree::XPathEngine::Function)  
      1 perl(Tree::XPathEngine::Literal)  
      1 perl(Tree::XPathEngine::LocationPath)  
      1 perl(Tree::XPathEngine::NodeSet)  
      1 perl(Tree::XPathEngine::Number)  
      1 perl(Tree::XPathEngine::Root)  
      1 perl(Tree::XPathEngine::Step)  
      1 perl(Tree::XPathEngine::Variable)  
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Tree-XPathEngine-0.05-1.fc17.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3759378). Ok.

Otherwise package is in line with Fedora and Perl packaging guidelines.


Please consider fixing all `TODO' items before building this package.

Resolution: Package APPROVED.

Comment 2 Petr Šabata 2012-02-03 14:53:36 UTC
(In reply to comment #1)
> Description verified from lib/Tree/XPathEngine.pm. Ok.
> TODO: Use plural of `module' in `module/classes'.

Ok.

> TODO: Require perl(POSIX) (lib/Tree/XPathEngine/Function.pm:339). Please note
> the module is not needed at test-time.

POSIX is not a CPAN package, it's provided directly by perl.

> Resolution: Package APPROVED.

Thank you.

Comment 3 Petr Šabata 2012-02-03 14:54:23 UTC
New Package SCM Request
=======================
Package Name: perl-Tree-XPathEngine
Short Description: Re-usable XPath engine
Owners: psabata mmaslano ppisar
Branches: 
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2012-02-03 15:00:11 UTC
Git done (by process-git-requests).

Comment 5 Petr Šabata 2012-02-03 15:12:50 UTC
Thanks, Jon.


Note You need to log in before you can comment on or make changes to this bug.