Hide Forgot
Description of problem: There is no Icon tag in freecol.spec. Version-Release number of selected component (if applicable): All, looking at freecol-0.10.3-2.fc17 in rawhide. How reproducible: Always. Steps to Reproduce: 1. grep Icon freecol.spec or look at the packagers site:-) Actual results: No useful icon shown. Expected results: The usual FreeCol galleon icon is used. (<source>/data/rules/classic/resources/images/units/galleon.png). Additional info: Submitted by a freecol developer.
The spec file does install an icon. Though you need to grep for "icon" not "Icon". I also see an image of a galleon in the menu for freecol. And in gnome3 I can see the freecol icon on the application list. Can you provide some more details on where you aren't seeing it?
I agree the menus work. To see what I am referring to, go to the packagers site: https://community.dev.fedoraproject.org/packages/freecol. The icon shown there is just the default plain cardboard box. AFAICT this icon (shown here and in graphical package managers generally) is derived from the Icon: line in the rpm header, which freecol.spec lacks. I did give the wrong image file above however: <source>/data/freecol.png is the correct one. One final thing: 0.10.5 is out, with roughly 40 bugfixes including a couple of nasty game hangs.
I don't think Fedora uses the Icon tag in spec files. It gets used in Desktop files. I can ask on the packaging list about this. Does that web page expect the path to point to where the icon will be installed? I built 0.10.5 yesterday for rawhide (f18) and branched (f17). I am not the main packager for this and am not sure about doing builds for f15 and f16. I would expect we will after a bit.
I admit I am just assuming the packaging website is using the spec. It seemed logical is its a rather rpm oriented site. If it is actually the desktop file, then something else is broken as AFAICT even the freecol 0.9.5 package contains a .desktop with an Icon entry, yet apper does not display the icon (on F16, fully updated, KDE). Indeed apper only displays icons for gnome-games and kdegames out of the entire Games section, but I can not work out why gnome-games is showing what looks to be the sudoku icon. Hopefully the packaging people know what is happening. Good to hear 0.10.5 is good for F17, no urgency IMHO for F15,16. 0.10.4 was a brown-paper-bag release, but 0.10.5 is looking good thus far.
Since this seems to be a packaging tools issue and not a freecol issue I'm hereby closing this bug.
I heard back from the packaging list and in general Fedora doesn't use the Icon tag in spec files. I was given the names of a couple of people responsible for the web app and will pursue this with them.
This issue is probably related to freecol switching to an svg icon rather than using multiple png icons. The issue has been reported to the apps team. It really will need to get fixed there if this is the problem.
This is being tracked at https://fedorahosted.org/fedoracommunity/ticket/385, but I'll let you know when it gets resolved.