Bug 787775 - /usr/bin/pinentry should not check if stderr is opened
Summary: /usr/bin/pinentry should not check if stderr is opened
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: pinentry
Version: 22
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-06 17:18 UTC by Šimon Lukašík
Modified: 2016-01-17 17:55 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-01-14 12:25:41 UTC
Type: ---


Attachments (Terms of Use)
pinenrty-wrapper patch (541 bytes, patch)
2012-02-06 17:24 UTC, Šimon Lukašík
no flags Details | Diff

Description Šimon Lukašík 2012-02-06 17:18:42 UTC
Description of problem:
/usr/bin/pinentry checks if stderr is opened (by `test -t 2`)
before it launches /usr/bin/pinentry-curses.

Here the problem comes when /usr/bin/pinentry is launched by gpg-agent,
then the `test -t 2` returns false. However, it is completely valid
scenario, because the tty terminal can be established via Assuan protocol.

When pinentry-gtk is installed, this problem not appear, because
pinentry-gtk can fall-back to pinentry-curses

Version-Release number of selected component (if applicable):
pinentry-0.8.1-4.fc16.x86_64
gnupg2-2.0.18-2.fc16.x86_64

How reproducible:
deterministic

Steps to Reproduce:
1. # yum remove -y pinentry-gtk pinentry-qt
2. $ gpg2 --output hosts.gpg --symmetric /etc/hosts
3.

  
Actual results:
gpg: problem with the agent: No pinentry
gpg: error creating passphrase: Operation cancelled
gpg: symmetric encryption of `/etc/hosts' failed: Operation cancelled

Expected results:
pinentry-ncurses is started and the hosts file gets encrypted.

Additional info:
This is a regression against Fedora 13.

Comment 1 Šimon Lukašík 2012-02-06 17:24:58 UTC
Created attachment 559697 [details]
pinenrty-wrapper patch

Comment 2 Fedora End Of Life 2013-04-03 17:13:37 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 3 Fedora Admin XMLRPC Client 2014-07-19 17:59:54 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 4 Fedora End Of Life 2015-01-09 21:55:57 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2015-02-18 13:40:55 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 6 Šimon Lukašík 2015-02-19 08:37:06 UTC
Hey, trying to poke here. Normally, I wouldn't re-open, but here is a patch attached! ;-)

Comment 7 Boris Ranto 2016-01-14 12:25:41 UTC
Hi, this should already be fixed in fedora 21+ -- I did a major rehaul of the wrapper in 2014 and it should cover this case just as well.

Comment 8 Šimon Lukašík 2016-01-17 17:55:52 UTC
Great. Thanks!


Note You need to log in before you can comment on or make changes to this bug.