Spec URL: http://berrange.fedorapeople.org/review/perl-Cairo-GObject/perl-Cairo-GObject.spec SRPM URL: http://berrange.fedorapeople.org/review/perl-Cairo-GObject/perl-Cairo-GObject-1.001-1.fc16.src.rpm Description: Perl module to integrate Cairo into the Glib type system. NB. This new package is a pre-req to allow me to update perl-Gtk3 to the latest upstream version.
FYI here is a successful F17 scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=3768527 $ rpmlint /home/berrange/rpmbuild/SRPMS/perl-Cairo-GObject-1.001-1.fc16.src.rpm1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/berrange/rpmbuild/RPMS/x86_64/perl-Cairo-GObject-1.001-1.fc16.x86_64.rpm perl-Cairo-GObject.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Cairo-GObject-1.001/LICENSE 1 packages and 0 specfiles checked; 1 errors, 0 warnings. The FSF address problem is one shared by most of the Perl GLib/Gtk related modules. In previous tickets filed upstream., they have indicated their intent to address this problem in future releases.
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [-]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package meets the Packaging Guidelines. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generates any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. (the license stuff) [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/contyk/src/review/788074/Cairo-GObject-1.001.tar.gz : MD5SUM this package : 7e126a3424d9eab91b006b2a7ce09cb8 MD5SUM upstream package : 7e126a3424d9eab91b006b2a7ce09cb8 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [-]: SHOULD Spec use %global instead of %define. Issues: TODO: Since you seem to plan this for F17 only, drop BuildRoot & friends TODO: ...and %defattr TODO: perl(XSLoader) lives on CPAN, it would be nice to include it in BRs TODO: META.json and perl-Cairo-GObject.doap aren't interesting for end-users, remove them from %doc FIX: Filter out underspecified runtime dependencies or remove your versioned perl(Cairo) and perl(Glib) Requires. Consider fixing the optional TODO points. Not approving yet. Generated by fedora-review 0.1.1 External plugins:
Uploaded an updated spec file to the same URL with all TODO & FIX items addressed
Looks good. Approving.
New Package SCM Request ======================= Package Name: perl-Cairo-GObject Short Description: Perl module to integrate Cairo into the Glib type system Owners: berrange Branches: f16 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Cairo-GObject-1.001-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Cairo-GObject-1.001-1.fc16
perl-Cairo-GObject-1.001-1.fc16 has been pushed to the Fedora 16 stable repository.