Bug 788137

Created attachment 559978 [details]
Proposed patch

Description of problem:
Swig allows to define accessor functions (set, get) to a member variable. The swig mechanism to handle set function is broken in swig-1.3.40-6.el6.

This prevents building of libsolv EPEL package.

This bug has been fixed in swig 2.0.4 (or sooner, I didn't check). I have backported the bugfix from 2.0.4, so the code for accessors generated by swig-1.3.40 and swig-2.0.4 is identical. This solved the problem.

Version-Release number of selected component (if applicable):
swig-1.3.40-6.el6

How reproducible:
Always


Steps to Reproduce:
From libsolv (bindings/solv.i):
%extend XSolvable {
  const char *name;
  %{
    SWIGINTERN void XSolvable_name_set(XSolvable *xs, const char *name) {
      Pool *pool = xs->pool;
      pool->solvables[xs->id].name = pool_str2id(pool, name, 1);
    }
    SWIGINTERN const char *XSolvable_name_get(XSolvable *xs) {
      Pool *pool = xs->pool;
      return pool_id2str(pool, pool->solvables[xs->id].name);
    }
}

Generated code (set accessor wrapper; the code tries to assign to a void function call):
SWIGINTERN PyObject *_wrap_XSolvable_name_set(PyObject *SWIGUNUSEDPARM(self), PyObject *args) {
...
    arg2 = (char *)(buf2);
  if (arg2) {
    size_t size = strlen((const char *)((const char *)(arg2))) + 1;
    XSolvable_name_set(arg1,(char const *)arg2) = (char const *)(char *)memcpy((char *)malloc((size)*sizeof(char)), arg2, sizeof(char)*(size));
  } else {
    XSolvable_name_set(arg1,(char const *)arg2) = 0;
  }
}


Compilation:
/builddir/build/BUILD/libsolv/bindings/python/solv_python.c: In function '_wrap_XSolvable_name_set':
/builddir/build/BUILD/libsolv/bindings/python/solv_python.c:5334: error: invalid use of void expression
/builddir/build/BUILD/libsolv/bindings/python/solv_python.c:5336: error: invalid use of void expression