Bug 788993 - Log Collector doesn't return appropriate return codes
Summary: Log Collector doesn't return appropriate return codes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-logcollector
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Sandro Bonazzola
QA Contact:
URL:
Whiteboard: integration
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-09 14:27 UTC by Lukas Bednar
Modified: 2013-07-25 20:50 UTC (History)
7 users (show)

Fixed In Version: ovirt-log-collector-3.2.1-1.fc18.noarch.rpm
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-25 20:50:29 UTC
oVirt Team: ---

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 12403 0 None None None Never

Description Lukas Bednar 2012-02-09 14:27:35 UTC 
Description of problem:

when I mess up password for REST_API it is not able to retrieve data from hypervisors which means generate incomplete outputs, though that it returns 0.

Return values:
    0: The program ran to completion with no errors.
    1: The program encountered a critical failure and stopped.
    2: The program encountered a problem gathering data but was able to continue.


Version-Release number of selected component (if applicable):
ovirt-engine-log-collector-3.0.0_0001-1.6.fc16.x86_64

How reproducible:
just run LC with wrong password


Steps to Reproduce:
1. engine-log-collector -p WRONG_PASSWORD collect
2. echo $?
  
Actual results:
0

Expected results:
2 or something else != 0
Comment 1 Itamar Heim 2012-12-17 07:26:19 UTC 
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.
Comment 3 Sandro Bonazzola 2013-03-12 09:24:58 UTC 
patch merged upstream master: http://gerrit.ovirt.org/gitweb?p=ovirt-log-collector.git;a=commit;h=ceb44bd051f0db52f9d725e6fa7b3d37a7d06892
Note You need to log in before you can comment on or make changes to this bug.