Hide Forgot
Spec URL: http://npmccallum.fedorapeople.org/libverto-jsonrpc/libverto-jsonrpc.spec SRPM URL: http://npmccallum.fedorapeople.org/libverto-jsonrpc/libverto-jsonrpc-0.1.0-1.fc16.src.rpm Description: A library for doing JSON-RPC over a socket, using the libverto API.
libverto-jsonrpc.x86_64: E: explicit-lib-dependency libverto-module-base libverto-jsonrpc-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 1 warnings. See the documentation for libverto to explain the dependency on libverto-module-base. libverto-jsonrpc-devel depends on libverto-jsonrpc which contains the appropriate documentation.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3786956
SRPM: http://npmccallum.fedorapeople.org/libverto-jsonrpc/libverto-jsonrpc-0.1.0-2.fc16.src.rpm SPEC: http://npmccallum.fedorapeople.org/libverto-jsonrpc/libverto-jsonrpc.spec * Mon Feb 13 2012 Nathaniel McCallum <nathaniel> - 0.1.0-2 - Remove libverto-module-base dependency After some further thought, this dependency properly belongs in the app that consumes libverto-jsonrpc.
I'm acking this review with only one (non-mandatory) recommendation. Instead of %{_includedir}/* it would be a good idea to list the headers explicitly so in the future if you grow a new public header, it won't be included accidentally. (Or if you accidentally stop installing one in the right location, you'll know immediately).
New Package SCM Request ======================= Package Name: libverto-json Short Description: JSON-RPC support for libverto Owners: npmccallum Branches: f16 f17 master InitialCC:
SCM request package name and BZ summary name don't match, please rectify. Thanks!
New Package SCM Request ======================= Package Name: libverto-jsonrpc Short Description: JSON-RPC support for libverto Owners: npmccallum Branches: f16 f17 master InitialCC: Thanks for the catch!
Git done (by process-git-requests).