Bug 790193 - pulp-admin accepts any argument after end of options
Summary: pulp-admin accepts any argument after end of options
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Pulp
Classification: Retired
Component: z_other
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: pulp-bugs
QA Contact: Preethi Thomas
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-13 21:18 UTC by James Slagle
Modified: 2013-09-27 14:14 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-27 14:14:07 UTC


Attachments (Terms of Use)

Description James Slagle 2012-02-13 21:18:10 UTC
After any syntactically correct pulp-admin command, you can type any string you want and the command will still run.

We should have better input validation and throw up a help message instead in this case.  The reason being is that we don't know if the arbitrary string was meant to be another option, and now we've executed a command the user didn't intend.

Here's an example. I wanted to sync a repo in the foreground.  I typo'd "-F" as "0F":

# pulp-admin repo sync --id candlepin-x86_64 --limit 5 0F

The command still ran, but was sync'ing in the background.

This seems to apply to any command:

$ pulp-admin repo list monkies

will do a repo list.

Comment 1 Michael Hrivnak 2013-09-27 14:14:07 UTC
this seems to have been fixed at some point.


Note You need to log in before you can comment on or make changes to this bug.